From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx28evk: Remove fecmxc_mii_postcall()
Date: Fri, 21 Sep 2012 23:12:27 +0200 [thread overview]
Message-ID: <201209212312.27565.marex@denx.de> (raw)
In-Reply-To: <1348257653-22002-1-git-send-email-fabio.estevam@freescale.com>
Dear Fabio Estevam,
> fecmxc_mii_postcall() is specific to the KSZ9021 PHY on m28evk and
> should not be used on mx28evk, which has LAN8270 instead.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Marek Vasut <marex@denx.de>
This is a fix, so should go into current release.
> ---
> board/freescale/mx28evk/mx28evk.c | 25 -------------------------
> 1 file changed, 25 deletions(-)
>
> diff --git a/board/freescale/mx28evk/mx28evk.c
> b/board/freescale/mx28evk/mx28evk.c index d782aea..6e719ff 100644
> --- a/board/freescale/mx28evk/mx28evk.c
> +++ b/board/freescale/mx28evk/mx28evk.c
> @@ -100,19 +100,6 @@ int board_mmc_init(bd_t *bis)
>
> #ifdef CONFIG_CMD_NET
>
> -#define MII_OPMODE_STRAP_OVERRIDE 0x16
> -#define MII_PHY_CTRL1 0x1e
> -#define MII_PHY_CTRL2 0x1f
> -
> -int fecmxc_mii_postcall(int phy)
> -{
> - miiphy_write("FEC1", phy, MII_BMCR, 0x9000);
> - miiphy_write("FEC1", phy, MII_OPMODE_STRAP_OVERRIDE, 0x0202);
> - if (phy == 3)
> - miiphy_write("FEC1", 3, MII_PHY_CTRL2, 0x8180);
> - return 0;
> -}
> -
> int board_eth_init(bd_t *bis)
> {
> struct mxs_clkctrl_regs *clkctrl_regs =
> @@ -152,24 +139,12 @@ int board_eth_init(bd_t *bis)
> return -EINVAL;
> }
>
> - ret = fecmxc_register_mii_postcall(dev, fecmxc_mii_postcall);
> - if (ret) {
> - puts("FEC MXS: Unable to register FEC0 mii postcall\n");
> - return ret;
> - }
> -
> dev = eth_get_dev_by_name("FEC1");
> if (!dev) {
> puts("FEC MXS: Unable to get FEC1 device entry\n");
> return -EINVAL;
> }
>
> - ret = fecmxc_register_mii_postcall(dev, fecmxc_mii_postcall);
> - if (ret) {
> - puts("FEC MXS: Unable to register FEC1 mii postcall\n");
> - return ret;
> - }
> -
> return ret;
> }
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-09-21 21:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 20:00 [U-Boot] [PATCH] mx28evk: Remove fecmxc_mii_postcall() Fabio Estevam
2012-09-21 21:12 ` Marek Vasut [this message]
2012-09-24 8:46 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209212312.27565.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.