From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFM7e-0005qX-UA for qemu-devel@nongnu.org; Sat, 22 Sep 2012 05:35:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFM7a-0001Uo-Mj for qemu-devel@nongnu.org; Sat, 22 Sep 2012 05:35:38 -0400 Received: from hall.aurel32.net ([88.191.126.93]:60391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFM7a-0001Uf-GT for qemu-devel@nongnu.org; Sat, 22 Sep 2012 05:35:34 -0400 Date: Sat, 22 Sep 2012 11:35:31 +0200 From: Aurelien Jarno Message-ID: <20120922093531.GC23250@ohm.aurel32.net> References: <1348256598-8146-1-git-send-email-aurelien@aurel32.net> <1348256598-8146-8-git-send-email-aurelien@aurel32.net> <505CF574.80901@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <505CF574.80901@twiddle.net> Subject: Re: [Qemu-devel] [PATCH v2 07/10] tcg/optimize: further optimize brcond/movcond/setcond List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Fri, Sep 21, 2012 at 04:17:08PM -0700, Richard Henderson wrote: > On 09/21/2012 12:43 PM, Aurelien Jarno wrote: > > +/* Return 2 if the condition can't be simplified, and the result > > + of the condition (0 or 1) if it can */ > > Ok as-is. But I'd bike-shed the "fail" return to -1. > I have done it that way, as tmp is an unsigned value, and I didn't want to add another one. But that can be changed. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net