From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: LKML <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Pavel Emelyanov <xemul@parallels.com>,
Jiri Slaby <jslaby@suse.cz>
Subject: Re: [RFC] tty: Add get- ioctls to fetch tty status
Date: Sun, 23 Sep 2012 10:40:07 +0400 [thread overview]
Message-ID: <20120923064007.GA2994@moon> (raw)
In-Reply-To: <20120923010953.GA17663@kroah.com>
On Sat, Sep 22, 2012 at 06:09:53PM -0700, Greg Kroah-Hartman wrote:
> On Sun, Sep 23, 2012 at 01:52:32AM +0400, Cyrill Gorcunov wrote:
> > On Sun, Sep 23, 2012 at 12:11:44AM +0400, Cyrill Gorcunov wrote:
> > >
> > > > Sysfs is one value per file, you have three values here, please make 3
> > > > files.
> > > >
> > > > And document them in Documentation/ABI/.
> > >
> > > Hmm, sure Greg, I'll update. Thanks!
> >
> > Something like below I suppose? Look, if there will be no complains
> > on tech aspects on the patch (locking and tty refs) -- I'll update
> > Documentation. Just want be sure I've made no mistakes here.
> >
> > Another question -- would not it be worth to wrap code with
> > CONFIG_CHECKPOINT_RESTORE?
>
> Alan's point stands, what's the use of this if it can instantly change
> after you read the value?
We use it when we do a checkpoint, ie when tasks are stopped. I think it's
close to data obtained from procfs (ie valid once you read it but can be
changed right after that operation). Maybe I should put everything to
procfs, or stick back with ioctl calls?
next prev parent reply other threads:[~2012-09-23 6:40 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 9:56 [RFC] tty: Add get- ioctls to fetch tty status Cyrill Gorcunov
2012-09-13 11:46 ` Jiri Slaby
2012-09-13 11:51 ` Cyrill Gorcunov
2012-09-13 12:51 ` Alan Cox
2012-09-13 12:54 ` Cyrill Gorcunov
2012-09-13 16:25 ` Alan Cox
2012-09-13 16:41 ` Cyrill Gorcunov
2012-09-22 18:06 ` Cyrill Gorcunov
2012-09-22 20:07 ` Greg Kroah-Hartman
2012-09-22 20:11 ` Cyrill Gorcunov
2012-09-22 21:52 ` Cyrill Gorcunov
2012-09-23 1:09 ` Greg Kroah-Hartman
2012-09-23 6:40 ` Cyrill Gorcunov [this message]
2012-09-23 14:46 ` H. Peter Anvin
2012-09-23 15:21 ` Cyrill Gorcunov
2012-09-24 14:14 ` Cyrill Gorcunov
2012-09-27 14:05 ` Cyrill Gorcunov
2012-09-27 14:14 ` Alan Cox
2012-09-27 14:14 ` Cyrill Gorcunov
2012-09-27 14:17 ` H. Peter Anvin
2012-09-27 14:21 ` Cyrill Gorcunov
2012-09-27 14:43 ` H. Peter Anvin
2012-09-27 14:48 ` Cyrill Gorcunov
2012-09-27 15:05 ` H. Peter Anvin
2012-09-27 15:13 ` Alan Cox
2012-09-27 15:23 ` Cyrill Gorcunov
2012-09-27 16:00 ` Alan Cox
2012-09-27 16:06 ` Cyrill Gorcunov
2012-09-27 15:47 ` Cyrill Gorcunov
2012-09-22 23:15 ` Alan Cox
2012-09-23 1:43 ` Eric W. Biederman
2012-09-23 6:40 ` Cyrill Gorcunov
2012-09-23 14:44 ` H. Peter Anvin
2012-09-23 15:22 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120923064007.GA2994@moon \
--to=gorcunov@openvz.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.