From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Antti Palosaari <crope@iki.fi>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 07/16] rtl2830: use .get_if_frequency()
Date: Sun, 23 Sep 2012 20:17:42 -0300 [thread overview]
Message-ID: <20120923201742.4eaf7455@redhat.com> (raw)
In-Reply-To: <1347495837-3244-7-git-send-email-crope@iki.fi>
Em Thu, 13 Sep 2012 03:23:48 +0300
Antti Palosaari <crope@iki.fi> escreveu:
> Use .get_if_frequency() as all used tuner drivers
> (mt2060/qt1010/mxl5005s) supports it.
>
> Signed-off-by: Antti Palosaari <crope@iki.fi>
> @@ -240,26 +237,6 @@ static int rtl2830_init(struct dvb_frontend *fe)
> if (ret)
> goto err;
>
> - num = priv->cfg.if_dvbt % priv->cfg.xtal;
> - num *= 0x400000;
> - num = div_u64(num, priv->cfg.xtal);
> - num = -num;
> - if_ctl = num & 0x3fffff;
> - dev_dbg(&priv->i2c->dev, "%s: if_ctl=%08x\n", __func__, if_ctl);
> -
> - ret = rtl2830_rd_reg_mask(priv, 0x119, &tmp, 0xc0); /* b[7:6] */
> - if (ret)
> - goto err;
> -
> - buf[0] = tmp << 6;
> - buf[0] |= (if_ctl >> 16) & 0x3f;
> - buf[1] = (if_ctl >> 8) & 0xff;
> - buf[2] = (if_ctl >> 0) & 0xff;
Patch applied, but there was a context difference above:
--- a/drivers/media/dvb-frontends/rtl2830.c
+++ b/drivers/media/dvb-frontends/rtl2830.c
@@ -182,9 +182,6 @@ static int rtl2830_init(struct dvb_frontend *fe)
@@ -28,7 +50,7 @@ index eca1d72..3954760 100644
- goto err;
-
- buf[0] = tmp << 6;
-- buf[0] = (if_ctl >> 16) & 0x3f;
+- buf[0] |= (if_ctl >> 16) & 0x3f;
- buf[1] = (if_ctl >> 8) & 0xff;
- buf[2] = (if_ctl >> 0) & 0xff;
-
(that's the diff between the patch applied and your original one)
--
Regards,
Mauro
next prev parent reply other threads:[~2012-09-23 23:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 0:23 [PATCH 01/16] af9033: use Kernel dev_foo() logging Antti Palosaari
2012-09-13 0:23 ` [PATCH 02/16] af9013: " Antti Palosaari
2012-09-13 0:23 ` [PATCH 03/16] ec100: " Antti Palosaari
2012-09-13 0:23 ` [PATCH 04/16] ec100: improve I2C routines Antti Palosaari
2012-09-13 0:23 ` [PATCH 05/16] hd29l2: use Kernel dev_foo() logging Antti Palosaari
2012-09-13 0:23 ` [PATCH 06/16] rtl2830: " Antti Palosaari
2012-09-13 0:23 ` [PATCH 07/16] rtl2830: use .get_if_frequency() Antti Palosaari
2012-09-23 23:17 ` Mauro Carvalho Chehab [this message]
2012-09-24 0:08 ` Antti Palosaari
2012-09-24 0:23 ` Mauro Carvalho Chehab
2012-09-24 0:28 ` Antti Palosaari
2012-09-24 2:46 ` Mauro Carvalho Chehab
2012-09-13 0:23 ` [PATCH 08/16] rtl2830: declare two tables as constant Antti Palosaari
2012-09-13 0:23 ` [PATCH 09/16] af9015: use Kernel dev_foo() logging Antti Palosaari
2012-09-13 0:23 ` [PATCH 10/16] af9015: improve af9015_eeprom_hash() Antti Palosaari
2012-09-13 0:23 ` [PATCH 11/16] af9015: correct few error codes Antti Palosaari
2012-09-13 0:23 ` [PATCH 12/16] af9035: use Kernel dev_foo() logging Antti Palosaari
2012-09-13 0:23 ` [PATCH 13/16] au6610: " Antti Palosaari
2012-09-13 0:23 ` [PATCH 14/16] gl861: " Antti Palosaari
2012-09-13 0:23 ` [PATCH 15/16] ec168: " Antti Palosaari
2012-09-13 0:23 ` [PATCH 16/16] ce6230: " Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120923201742.4eaf7455@redhat.com \
--to=mchehab@redhat.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.