From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad@kernel.org>
Subject: Re: [PATCH] x86: retrieve keyboard shift status flags
 from BIOS
Date: Mon, 24 Sep 2012 09:25:04 -0400
Message-ID: <20120924132504.GB17928@phenom.dumpdata.com>
References: <504F3F8A020000780009A8F9@nat28.tlf.novell.com>
	<20120921163406.GC4780@phenom.dumpdata.com>
	<506056A6020000780009D453@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <506056A6020000780009D453@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> (but also see below)
.. snip..
> > flags. */
> >  struct xenpf_firmware_info {
> >  	/* IN variables. */
> >  	uint32_t type;
> > @@ -142,6 +143,8 @@ struct xenpf_firmware_info {
> >  			/* must refer to 128-byte buffer */
> >  			GUEST_HANDLE(uchar) edid;
> >  		} vbeddc_info; /* XEN_FW_VBEDDC_INFO */
> > +		uint8_t kbd_shift_flags; /* XEN_FW_KBD_SHIFT_FLAGS */
> > +
> 
> I'd prefer to not have stray empty line here - if anything, it should
> go before the new union member.
> 

Done! Thx for the review.