From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v8] [RFC] early_malloc for DM added.
Date: Mon, 24 Sep 2012 16:19:50 +0200 [thread overview]
Message-ID: <201209241619.50452.marex@denx.de> (raw)
In-Reply-To: <CAEB7QLCgLJr4pEZDRooUrDjfikxyk-STE9n3XW_EQSP_j4qYrA@mail.gmail.com>
Dear Tomas Hlavacek,
[...]
> >> +static inline void *dmrealloc(void *oldmem, size_t bytes)
> >> +{
> >> +#ifdef CONFIG_SYS_EARLY_MALLOC
> >> + if (early_malloc_active())
> >> + return NULL;
> >
> > I wonder how should this be implemented ... maybe early_malloc + standard
> > memcpy()
>
> How do you want me to fix all the pointers to the memcpyied part of
> heap then? I think this will not work unless I make some reservations
> for eventual growth for each and every early_mallocated area. And I
> think this is not good idea at all for early_malloc.
What exactly would you need to fix ? It's only a matter of allocating new block,
copying the existing data there and returning the pointer to the new block, no?
> I think there are two straight-forward possibilities: a) keep the
> empty implementation of dmrealloc() in early stage and avoid using it
> in code which might run in early stage, but retain the dm* version of
> the symbol. b) remove the dmrealloc() entirely which may have certain
> negative consequences, because it might be tempting to mix dmmalloc()
> and (non-dm*) realloc() calls which is obviously wrong.
>
> Tomas
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-09-24 14:19 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 12:12 [U-Boot] [PATCH 1/1] [RFC] DM: early_malloc for DM added Tomas Hlavacek
2012-08-27 12:18 ` Marek Vasut
2012-08-27 12:37 ` Tomas Hlavacek
2012-08-27 12:42 ` [U-Boot] [PATCHv2 " Tomas Hlavacek
2012-08-27 23:02 ` Graeme Russ
2012-08-28 0:11 ` Graeme Russ
2012-08-28 0:18 ` Graeme Russ
2012-09-18 7:13 ` [U-Boot] [PATCHv4] " Tomas Hlavacek
2012-09-18 10:57 ` Marek Vasut
2012-09-18 23:29 ` Graeme Russ
2012-09-18 23:33 ` Marek Vasut
2012-09-18 23:44 ` Graeme Russ
2012-09-18 23:53 ` Marek Vasut
2012-09-19 18:29 ` Tom Rini
2012-09-22 0:37 ` Tomas Hlavacek
2012-09-18 23:25 ` Graeme Russ
2012-09-22 0:25 ` [U-Boot] [PATCH v5] [RFC] " Tomas Hlavacek
2012-09-22 0:28 ` Marek Vasut
2012-09-22 7:52 ` Tomas Hlavacek
2012-09-22 13:19 ` Marek Vasut
2012-09-22 22:09 ` [U-Boot] [PATCH v6] " Tomas Hlavacek
2012-09-23 13:06 ` Graeme Russ
2012-09-23 15:30 ` Tomas Hlavacek
2012-09-23 15:38 ` [U-Boot] [PATCH v7] " Tomas Hlavacek
2012-09-23 16:15 ` [U-Boot] [PATCH v8] " Tomas Hlavacek
2012-09-23 16:32 ` Wolfgang Denk
2012-09-23 16:47 ` Tomas Hlavacek
2012-09-24 21:48 ` Tom Rini
2012-09-23 23:11 ` Marek Vasut
2012-09-24 14:16 ` Tomas Hlavacek
2012-09-24 14:19 ` Marek Vasut [this message]
2012-09-25 0:37 ` Graeme Russ
2012-09-25 8:43 ` Tomas Hlavacek
2012-09-25 9:09 ` Graeme Russ
2012-09-25 23:04 ` Graeme Russ
2012-09-26 10:16 ` Tomas Hlavacek
2012-09-26 23:03 ` Graeme Russ
2012-09-24 0:00 ` Graeme Russ
2012-09-24 0:35 ` Tomas Hlavacek
2012-09-24 0:46 ` Graeme Russ
2012-10-24 23:49 ` [U-Boot] [PATCH v9] [RFC] Add dmmalloc module for DM Tomas Hlavacek
2012-10-25 1:40 ` Graeme Russ
2012-10-25 19:16 ` Tomas Hlavacek
2012-10-25 23:04 ` Graeme Russ
2012-10-28 23:20 ` [U-Boot] [PATCH v10] " Tomas Hlavacek
2013-11-05 15:26 ` Mateusz Zalega
2013-11-05 17:17 ` Tom Rini
2013-11-05 17:26 ` Mateusz Zalega
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209241619.50452.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.