From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Mark Salter <msalter@redhat.com>
Cc: linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] c/r: prctl: fix build error for no-MMU case
Date: Tue, 25 Sep 2012 01:55:07 +0400 [thread overview]
Message-ID: <20120924215507.GL16532@moon> (raw)
In-Reply-To: <1348522892-12705-1-git-send-email-msalter@redhat.com>
On Mon, Sep 24, 2012 at 05:41:32PM -0400, Mark Salter wrote:
> Commit 1ad75b9e1 added some address checking to prctl_set_mm()
> used by checkpoint-restore. This causes a build error for no-MMU
> systems:
>
> kernel/sys.c: In function 'prctl_set_mm':
> kernel/sys.c:1868:34: error: 'mmap_min_addr' undeclared (first use in this function)
>
> The test for mmap_min_addr doesn't make a lot of sense for no-MMU
> code as noted in commit 6e1415467. This patch defines mmap_min_addr
> as 0UL in the no-MMU case so that the compiler will optimize away
> tests for "addr < mmap_min_addr".
>
> Signed-off-by: Mark Salter <msalter@redhat.com>
Thanks, Mark! I should add that this mmap_min_addr currently
referenced in other parts of code only under CONFIG_MMU so this
definition in header should not break anything.
Reviewed-by: Cyrill Gorcunov <gorcunov@openvz.org>
prev parent reply other threads:[~2012-09-24 21:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 21:41 [PATCH] c/r: prctl: fix build error for no-MMU case Mark Salter
2012-09-24 21:55 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120924215507.GL16532@moon \
--to=gorcunov@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msalter@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.