From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amit Shah Subject: Re: [PATCHv4] virtio_console: Add support for remoteproc serial Date: Tue, 25 Sep 2012 12:20:25 +0530 Message-ID: <20120925065025.GF32657@amit.redhat.com> References: <1348489987-6768-1-git-send-email-sjur.brandeland@stericsson.com> <20120924174523.GA14390@amit.redhat.com> <81C3A93C17462B4BBD7E272753C1057923BD79D728@EXDCVYMBSTM005.EQ1STM.local> <20120925040158.GC32657@amit.redhat.com> <87sja63c9b.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <87sja63c9b.fsf@rustcorp.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Rusty Russell Cc: "sjurbren@gmail.com" , Arnd Bergmann , "Michael S. Tsirkin" , Linus Walleij , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , Sjur BRENDELAND List-Id: virtualization@lists.linuxfoundation.org On (Tue) 25 Sep 2012 [14:55:04], Rusty Russell wrote: > Amit Shah writes: > > > On (Mon) 24 Sep 2012 [23:50:01], Sjur BRENDELAND wrote: > >> Hi Amit, > >> > >> > I'm sorry for not being able to look at this earlier. > >> > >> No worries. I'll try to respin and retest this patch by tomorrow. > >> If you by any chance could find time to review so could make it in time > >> for 3.7 it would be great :-) > > > > I think it might be late for 3.7 already, I'd prefer to let this bake > > for a while, ensure it passes my test suites, at the least. But I'll > > let Rusty take the final call. > > It can make the next merge window, but it has to be done this week. > > I'm only allowing it this late because it's a new driver. It does change code shared with the 'older' console and serial ports, so the risk of regressions does exist. Amit From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753338Ab2IYGup (ORCPT ); Tue, 25 Sep 2012 02:50:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63173 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884Ab2IYGuo (ORCPT ); Tue, 25 Sep 2012 02:50:44 -0400 Date: Tue, 25 Sep 2012 12:20:25 +0530 From: Amit Shah To: Rusty Russell Cc: Sjur BRENDELAND , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "sjurbren@gmail.com" , "Michael S. Tsirkin" , Ohad Ben-Cohen , Linus Walleij , Arnd Bergmann Subject: Re: [PATCHv4] virtio_console: Add support for remoteproc serial Message-ID: <20120925065025.GF32657@amit.redhat.com> References: <1348489987-6768-1-git-send-email-sjur.brandeland@stericsson.com> <20120924174523.GA14390@amit.redhat.com> <81C3A93C17462B4BBD7E272753C1057923BD79D728@EXDCVYMBSTM005.EQ1STM.local> <20120925040158.GC32657@amit.redhat.com> <87sja63c9b.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sja63c9b.fsf@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (Tue) 25 Sep 2012 [14:55:04], Rusty Russell wrote: > Amit Shah writes: > > > On (Mon) 24 Sep 2012 [23:50:01], Sjur BRENDELAND wrote: > >> Hi Amit, > >> > >> > I'm sorry for not being able to look at this earlier. > >> > >> No worries. I'll try to respin and retest this patch by tomorrow. > >> If you by any chance could find time to review so could make it in time > >> for 3.7 it would be great :-) > > > > I think it might be late for 3.7 already, I'd prefer to let this bake > > for a while, ensure it passes my test suites, at the least. But I'll > > let Rusty take the final call. > > It can make the next merge window, but it has to be done this week. > > I'm only allowing it this late because it's a new driver. It does change code shared with the 'older' console and serial ports, so the risk of regressions does exist. Amit