From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: BUG() on unexpected HDMI register Date: Tue, 25 Sep 2012 10:35:24 +0200 Message-ID: <20120925083524.GC3824@bremse> References: <1348493576-3386-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-lb0-f177.google.com (mail-lb0-f177.google.com [209.85.217.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 5563D9E758 for ; Tue, 25 Sep 2012 01:35:30 -0700 (PDT) Received: by lbbgf7 with SMTP id gf7so1220770lbb.36 for ; Tue, 25 Sep 2012 01:35:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Mon, Sep 24, 2012 at 07:12:16PM -0300, Rodrigo Vivi wrote: > This was easy for me, feel free to use: > > Reviewed-by: Rodrigo Vivi Already merged to dinq before I've seen your r-b, thanks anyway for the review (and the patch obviously too). I've bikeshedded the actual fix a bit on irc (needs a clearer commit msg since 32 bytes is the limit and a comment explaining what's going on). -Daniel > > On Mon, Sep 24, 2012 at 10:32 AM, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > This should never happen, but the silent "return" makes me wonder > > every time I try to debug InfoFrame bugs, so promote this to BUG() to > > make sure people will complain if we ever break this. > > > > Signed-off-by: Paulo Zanoni > > --- > > drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c > > index 229897f..f9fb47c 100644 > > --- a/drivers/gpu/drm/i915/intel_hdmi.c > > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > > @@ -377,6 +377,7 @@ static void g4x_set_infoframes(struct drm_encoder *encoder, > > port = VIDEO_DIP_PORT_C; > > break; > > default: > > + BUG(); > > return; > > } > > > > @@ -435,6 +436,7 @@ static void ibx_set_infoframes(struct drm_encoder *encoder, > > port = VIDEO_DIP_PORT_D; > > break; > > default: > > + BUG(); > > return; > > } > > > > -- > > 1.7.10.4 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > -- > Rodrigo Vivi > Blog: http://blog.vivi.eng.br > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch