Re: [PATCH] perf test: Fix build failure

[Arnaldo Carvalho de Melo <acme@ghostprotocols.net>]

Em Tue, Sep 25, 2012 at 11:20:28AM +0900, Namhyung Kim escreveu:
> From: Namhyung Kim <namhyung.kim@lge.com>
> 
> The commit 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint
> format fields") added following build error:
> 
>   CC builtin-test.o
> builtin-test.c: In function ‘perf_evsel__test_field’:
> builtin-test.c:1216:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
> builtin-test.c: In function ‘perf_evsel__tp_sched_test’:
> builtin-test.c:1242:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> make: *** [builtin-test.o] Error 1


Interesting :-\

[acme@sandy linux]$ gcc --version
gcc (GCC) 4.4.6 20120305 (Red Hat 4.4.6-4)

Didn't catch this one...

Thanks,

- Arnaldo

> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/perf/builtin-test.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-test.c b/tools/perf/builtin-test.c
> index 32caf13cfe01..78b47a75a7c9 100644
> --- a/tools/perf/builtin-test.c
> +++ b/tools/perf/builtin-test.c
> @@ -1233,7 +1233,7 @@ static int perf_evsel__test_field(struct perf_evsel *evsel, const char *name,
>  		ret = -1;
>  	}
>  
> -	return 0;
> +	return ret;
>  }
>  
>  static int perf_evsel__tp_sched_test(void)
> @@ -1286,7 +1286,7 @@ static int perf_evsel__tp_sched_test(void)
>  	if (perf_evsel__test_field(evsel, "target_cpu", 4, true))
>  		ret = -1;
>  
> -	return 0;
> +	return ret;
>  }
>  
>  static struct test {
> -- 
> 1.7.11.4