From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH] ASoC: core: Configure pin muxing via pinctrl when registering a DAI
Date: Tue, 25 Sep 2012 07:11:47 -0400 [thread overview]
Message-ID: <20120925111146.GC4428@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CACRpkdZKL62n02maO7CJ4Q1mNFW+=nTFOF1CWcs3b1Od3mGBbg@mail.gmail.com>
On Mon, Sep 24, 2012 at 04:37:23PM +0200, Linus Walleij wrote:
> On Mon, Sep 24, 2012 at 12:17 PM, Mark Brown
> > Well, the problem here is that people keep wanting to add one shot
> > pinctrl calls in drivers which clearly suggests that it ought to be
> > factored out.
> OK so can we find some suitable middle ground here?
> Something like drivers could add some boolean flag to
> "opt-in" for the core to handle this or so?
Well, I don't know if we need to - it sounds like the platforms that are
running around adding these pinctrl calls to all the drivers are doing
it wrong and should be fixed.
> After all only some MMC drivers call up to
> mmc_regulator_set_ocr() to set voltages, it's optional
> but centralized.
This is mostly a historical thing, though - pinctrl is new.
next prev parent reply other threads:[~2012-09-25 11:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 7:54 [PATCH] ASoC: core: Configure pin muxing via pinctrl when registering a DAI Peter Ujfalusi
2012-09-21 11:13 ` Mark Brown
2012-09-21 13:16 ` Peter Ujfalusi
2012-09-21 14:55 ` Peter Ujfalusi
2012-09-22 15:23 ` Mark Brown
2012-09-21 16:23 ` Stephen Warren
2012-09-22 15:28 ` Mark Brown
2012-09-23 3:23 ` Stephen Warren
2012-09-24 9:20 ` Linus Walleij
2012-09-24 10:17 ` Mark Brown
2012-09-24 14:37 ` Linus Walleij
2012-09-25 11:11 ` Mark Brown [this message]
2012-09-25 11:24 ` Peter Ujfalusi
2012-09-25 11:43 ` Linus Walleij
2012-09-25 11:43 ` Mark Brown
2012-09-25 11:56 ` Linus Walleij
2012-09-25 12:24 ` Mark Brown
2012-09-25 17:00 ` Stephen Warren
2012-09-24 15:41 ` Stephen Warren
2012-09-25 11:22 ` Mark Brown
2012-09-24 8:34 ` Linus Walleij
2012-09-24 10:23 ` Mark Brown
2012-09-24 15:38 ` Stephen Warren
2012-09-22 15:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925111146.GC4428@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linus.walleij@linaro.org \
--cc=lrg@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.