From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX Date: Tue, 25 Sep 2012 08:27:06 -0700 Message-ID: <20120925152705.GB4840@atomide.com> References: <1348561590-13361-1-git-send-email-yegorslists@googlemail.com> <20120925083245.GH31374@n2100.arm.linux.org.uk> <50616F6A.80100@visionsystems.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-04-ewr.mailhop.org ([204.13.248.74]:63025 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756310Ab2IYP1R (ORCPT ); Tue, 25 Sep 2012 11:27:17 -0400 Content-Disposition: inline In-Reply-To: <50616F6A.80100@visionsystems.de> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Yegor Yefremov Cc: Russell King - ARM Linux , yegorslists@googlemail.com, linux-omap@vger.kernel.org, Dejan Gacnik , linux-arm-kernel@lists.infradead.org * Yegor Yefremov [120925 01:47]: > On 25.09.2012 10:32, Russell King - ARM Linux wrote: > > On Tue, Sep 25, 2012 at 10:26:30AM +0200, yegorslists@googlemail.com wrote: > >> From: Yegor Yefremov > >> > >> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB > >> of consistent DMA memory (da8xx frame buffer driver). > > > > Okay, so the patch description says "This needs to be 12 on this platform". > > > >> config FORCE_MAX_ZONEORDER > >> - int "Maximum zone order" if ARCH_SHMOBILE > >> - range 11 64 if ARCH_SHMOBILE > >> + int "Maximum zone order" if ARCH_SHMOBILE || SOC_AM33XX > >> + range 11 64 if ARCH_SHMOBILE || SOC_AM33XX > > > > but you leave it up to the user to select something that may not be > > suitable. Wouldn't _just_ adding: > > > > default "12" if SOC_AM33XX > > > > after the "range", and making no other changes be good enough and match > > what the patch description says? > > You're right. As we don't allocate anything, but increase the possible size, it shouldn't break anything. Tony is it O.K. with you? Sure. Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Tue, 25 Sep 2012 08:27:06 -0700 Subject: [PATCH v2] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX In-Reply-To: <50616F6A.80100@visionsystems.de> References: <1348561590-13361-1-git-send-email-yegorslists@googlemail.com> <20120925083245.GH31374@n2100.arm.linux.org.uk> <50616F6A.80100@visionsystems.de> Message-ID: <20120925152705.GB4840@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Yegor Yefremov [120925 01:47]: > On 25.09.2012 10:32, Russell King - ARM Linux wrote: > > On Tue, Sep 25, 2012 at 10:26:30AM +0200, yegorslists at googlemail.com wrote: > >> From: Yegor Yefremov > >> > >> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB > >> of consistent DMA memory (da8xx frame buffer driver). > > > > Okay, so the patch description says "This needs to be 12 on this platform". > > > >> config FORCE_MAX_ZONEORDER > >> - int "Maximum zone order" if ARCH_SHMOBILE > >> - range 11 64 if ARCH_SHMOBILE > >> + int "Maximum zone order" if ARCH_SHMOBILE || SOC_AM33XX > >> + range 11 64 if ARCH_SHMOBILE || SOC_AM33XX > > > > but you leave it up to the user to select something that may not be > > suitable. Wouldn't _just_ adding: > > > > default "12" if SOC_AM33XX > > > > after the "range", and making no other changes be good enough and match > > what the patch description says? > > You're right. As we don't allocate anything, but increase the possible size, it shouldn't break anything. Tony is it O.K. with you? Sure. Tony