From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Ivo Sieben <meltedpianoman@gmail.com>
Cc: Alan Cox <alan@linux.intel.com>,
Greg KH <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, RT <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH-v2] tty: prevent unnecessary work queue lock checking on flip buffer copy
Date: Tue, 25 Sep 2012 15:47:07 +0100 [thread overview]
Message-ID: <20120925154707.33aa2fa4@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <CAMSQXEHzWxqZZyAGrmdk-Grvz4EtTXFWivWnjQf5E4ReY88XoQ@mail.gmail.com>
> Or should drivers that use tty_schedule_flip() function never set the
> low_latency flag? (a quick scan indeed shows that all drivers that use
> the low_latency flag indeed make use of the tty_flip_buffer_push()
> function).
They should never do that - and adding a WARN_ON() will ensure we catch
anyone who offends.
I think thats worth doing as the resulting code is clearer and faster.
Alan
next prev parent reply other threads:[~2012-09-25 14:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 14:02 [PATCH] tty: prevent unnecessary work queue lock checking on flip buffer copy Ivo Sieben
2012-09-20 14:02 ` Ivo Sieben
2012-09-20 16:33 ` Alan Cox
2012-09-20 16:33 ` Alan Cox
2012-09-24 9:33 ` Ivo Sieben
2012-09-25 12:01 ` [PATCH-v2] " Ivo Sieben
2012-09-25 12:01 ` Ivo Sieben
2012-09-25 13:06 ` Alan Cox
2012-09-25 13:06 ` Alan Cox
2012-09-25 14:39 ` Ivo Sieben
2012-09-25 14:47 ` Alan Cox [this message]
2012-09-27 11:58 ` [PATCH-v3] " Ivo Sieben
2012-09-27 11:58 ` Ivo Sieben
2012-09-27 12:02 ` Ivo Sieben
2012-09-27 12:02 ` Ivo Sieben
2012-10-22 23:47 ` Greg KH
2012-10-23 10:16 ` Alan Cox
2012-10-24 12:35 ` [PATCH] [tty]: Report warning when low_latency flag is wrongly used Ivo Sieben
2012-10-24 12:35 ` Ivo Sieben
2012-10-24 14:32 ` Paul Gortmaker
2012-10-24 14:32 ` Paul Gortmaker
2012-10-24 18:22 ` [PATCH-v3] tty: prevent unnecessary work queue lock checking on flip buffer copy Greg KH
2012-09-27 13:15 ` Alan Cox
2012-09-27 13:15 ` Alan Cox
2012-09-27 16:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925154707.33aa2fa4@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=meltedpianoman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.