From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: drivers/pci/search.c:85:2: warning: suggest parentheses around assignment used as truth value
Date: Tue, 25 Sep 2012 19:49:02 +0000 [thread overview]
Message-ID: <20120925194901.GV4587@mwanda> (raw)
In-Reply-To: <CAE9FiQUnvwn+MjXaqiKANOQpeOOHg+X8DV0dFBks_JN1PmYdYw@mail.gmail.com>
On Tue, Sep 25, 2012 at 12:27:19PM -0700, Yinghai Lu wrote:
> On Tue, Sep 25, 2012 at 2:04 AM, Yuanhan Liu <yuanhan.liu@intel.com> wrote:
> > Hi Yinghai,
> >
> > FYI, there are new compile warnings show up in
> >
> > commit: 73ebfa72e382802b163a354fcb4d8dfea8ab58f3
> > title: PCI: kill pci_find_next_bus
> > date: 2012-09-25 01:21:07 -0700
> > config: x86_64-allyesdebian (attached as .config)
> >
> >
> > All error/warnings:
> >
> > drivers/edac/i7core_edac.c: In function 'i7core_pci_lastbus':
> > drivers/edac/i7core_edac.c:1299:2: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
>
> for checkpatch.pl ?
>
GCC.
> the code is like:
>
> #define for_each_pci_host_bridge(d) while ((d > pci_get_next_host_bridge(d)) != NULL)
In 73ebfa72e3828 "PCI: kill pci_find_next_bus" it doesn't have the
extra parens.
7b543663 (Yinghai Lu 2012-04-02 18:31:53 -0700 396) #define to_pci_host_bridge(n) container_of(n, struct pci_host_bridge, dev)
573a6050 (Yinghai Lu 2012-09-25 01:21:06 -0700 397) #define for_each_pci_host_bridge(d) while (d = pci_get_next_host_bridge(d))
573a6050 (Yinghai Lu 2012-09-25 01:21:06 -0700 398)
Maybe this got fixed later? Fengguang is probably testing
individual patches. If it's a non-rebase tree he has a way to mark
those...
regards,
dan carpenter
next prev parent reply other threads:[~2012-09-25 19:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 19:27 drivers/pci/search.c:85:2: warning: suggest parentheses around assignment used as truth value Yinghai Lu
2012-09-25 19:49 ` Dan Carpenter [this message]
2012-09-25 20:02 ` Yinghai Lu
2012-09-26 0:51 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925194901.GV4587@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.