All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: arm1176: Define arch_cpu_init() at the SoC level
Date: Tue, 25 Sep 2012 22:01:34 +0200	[thread overview]
Message-ID: <20120925220134.4755ef40@wker> (raw)
In-Reply-To: <1346552877-26539-1-git-send-email-swarren@wwwdotorg.org>

Hi Albert, Tom,

On Sat,  1 Sep 2012 19:27:56 -0700
Stephen Warren <swarren@wwwdotorg.org> wrote:

> Commit 86c6326 "ARM: arm1176: enable instruction cache in
> arch_cpu_init()" defined arch_cpu_init() in a file that is shared across
> all arm1176 SoCs. tnetv107x already implemented this function, which
> caused linking to break. Move the new conflicting arch_cpu_init() into
> arm1176/bcm2835/init.c so that it doesn't conflict; grep indicates this
> function is usually defined at the SoC-level, not the CPU-level, at least
> for ARM.
> 
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> ---
>  arch/arm/cpu/arm1176/bcm2835/Makefile |    2 +-
>  arch/arm/cpu/arm1176/bcm2835/init.c   |   24 ++++++++++++++++++++++++
>  arch/arm/cpu/arm1176/cpu.c            |    7 -------
>  3 files changed, 25 insertions(+), 8 deletions(-)
>  create mode 100644 arch/arm/cpu/arm1176/bcm2835/init.c

Could you please apply this patch? It fixes the build error for
tnetv107x_evm board. Currently MAKEALL doesn't build this board,
but this [1] patch enables building it and it fails. Thanks!

Anatolij

[1] http://patchwork.ozlabs.org/patch/180771

  parent reply	other threads:[~2012-09-25 20:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-02  2:27 [U-Boot] [PATCH] ARM: arm1176: Define arch_cpu_init() at the SoC level Stephen Warren
2012-09-14  0:17 ` Marek Vasut
2012-09-25 20:01 ` Anatolij Gustschin [this message]
2012-09-25 20:30   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120925220134.4755ef40@wker \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.