From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46847)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TGdsj-00045g-CN
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 18:45:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TGdsh-0003XT-VF
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 18:45:33 -0400
Received: from hall.aurel32.net ([88.191.126.93]:45397)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TGdsh-0003WR-Oi
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 18:45:31 -0400
Date: Wed, 26 Sep 2012 00:45:29 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20120925224529.GF23819@ohm.aurel32.net>
References: <1348523753-25083-1-git-send-email-rth@twiddle.net>
	<1348523753-25083-7-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1348523753-25083-7-git-send-email-rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 6/7] target-s390x: Avoid double
 CPU_LOG_TB_CPU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On Mon, Sep 24, 2012 at 02:55:52PM -0700, Richard Henderson wrote:
> This is already handled generically in cpu_exec.
> 
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  target-s390x/translate.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target-s390x/translate.c b/target-s390x/translate.c
> index 6fa76a0..4cc9225 100644
> --- a/target-s390x/translate.c
> +++ b/target-s390x/translate.c
> @@ -5220,7 +5220,6 @@ static inline void gen_intermediate_code_internal(CPUS390XState *env,
>          tb->icount = num_insns;
>      }
>  #if defined(S390X_DEBUG_DISAS)
> -    log_cpu_state_mask(CPU_LOG_TB_CPU, env, 0);
>      if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM)) {
>          qemu_log("IN: %s\n", lookup_symbol(pc_start));
>          log_target_disas(pc_start, dc.pc - pc_start, 1);
> -- 
> 1.7.11.4

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net