All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org, djwong@us.ibm.com
Subject: Re: [PATCH] ext4: fix double unlock buffer mess during fs-resize
Date: Tue, 25 Sep 2012 23:26:29 -0400	[thread overview]
Message-ID: <20120926032629.GB11468@thunk.org> (raw)
In-Reply-To: <1347012884-29484-1-git-send-email-dmonakhov@openvz.org>

On Fri, Sep 07, 2012 at 02:14:44PM +0400, Dmitry Monakhov wrote:
> bh_submit_read() is responsible for unlock bh on endio
> 
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>

Thanks, applied.  

BTW, I was checking the call sites for ext4_get_bitmap() in
fs/ext/resize.c, and we doing some extra work in
ext4_set_bitmap_checksums(); if the bitmap is uninitialized, then
there's no point in generating a checksum for it.

Something we can fix later, since it's harmless, although it is extra
unnecessary work.

					- Ted

      parent reply	other threads:[~2012-09-26  3:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-07 10:14 [PATCH] ext4: fix double unlock buffer mess during fs-resize Dmitry Monakhov
2012-09-25 15:25 ` [PATCH] PING " Dmitry Monakhov
2012-09-26  3:26 ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120926032629.GB11468@thunk.org \
    --to=tytso@mit.edu \
    --cc=djwong@us.ibm.com \
    --cc=dmonakhov@openvz.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.