All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: [block:for-3.7/core 20/21] fs/block_dev.c:1644:5: sparse: symbol 'blkdev_mmap' was not declared. Sho
Date: Wed, 26 Sep 2012 07:42:36 +0000	[thread overview]
Message-ID: <20120926074236.GB26028@localhost> (raw)

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

Hi Jens,

FYI, there are new sparse warnings show up in

tree:   git://git.kernel.dk/linux-block.git for-3.7/core
head:   62ac665ff9fc07497ca524bd20d6a96893d11071
commit: b87570f5d349661814b262dd5fc40787700f80d6 [20/21] Fix a crash when block device is read and block size is changed at the same time

+ fs/block_dev.c:1644:5: sparse: symbol 'blkdev_mmap' was not declared. Should it be static?

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu, Yuanhan Liu                              Intel Corporation

[-- Attachment #2: make-it-static-b87570f.diff --]
[-- Type: text/x-diff, Size: 462 bytes --]

diff --git a/fs/block_dev.c b/fs/block_dev.c
index cdfb625..5aa4683 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -1641,7 +1641,7 @@ ssize_t blkdev_aio_write(struct kiocb *iocb, const struct iovec *iov,
 }
 EXPORT_SYMBOL_GPL(blkdev_aio_write);
 
-int blkdev_mmap(struct file *file, struct vm_area_struct *vma)
+static int blkdev_mmap(struct file *file, struct vm_area_struct *vma)
 {
 	int ret;
 	struct block_device *bdev = I_BDEV(file->f_mapping->host);

             reply	other threads:[~2012-09-26  7:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26  7:42 Fengguang Wu [this message]
2012-09-26  7:59 ` [block:for-3.7/core 20/21] fs/block_dev.c:1644:5: sparse: symbol 'blkdev_mmap' was not declared Jens Axboe
2012-09-26 15:10   ` [PATCH] percpu-rw-semaphore: fix typos Mikulas Patocka
2012-10-04  0:58     ` [PATCH] percpu-rw-semaphore: lock splice methods Mikulas Patocka
2012-10-04  0:58       ` Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120926074236.GB26028@localhost \
    --to=fengguang.wu@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.