From: Ingo Molnar <mingo@kernel.org>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Vince Weaver <vincent.weaver@maine.edu>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
eranian@gmail.com, "Meadows,
Lawrence F" <lawrence.f.meadows@intel.com>
Subject: Re: [PATCH V2 1/1] perf, Add support for Xeon-Phi PMU
Date: Wed, 26 Sep 2012 09:56:10 +0200 [thread overview]
Message-ID: <20120926075610.GB2013@gmail.com> (raw)
In-Reply-To: <20120925201831.GB31526@moon>
* Cyrill Gorcunov <gorcunov@openvz.org> wrote:
> On Tue, Sep 25, 2012 at 12:23:23PM -0400, Vince Weaver wrote:
> > Hello
> >
> > This is an updated version of the patch. It uses
> > ARCH_PERFMON_EVENTSEL_INT for the DATA_READ event, with the assumption
> > that x86_pmu_hw_config() is going to set that bit anyway. This lets
> > the code get through the test for an event being 0 without
> > triggering -ENOENT.
>
> FWIW, looks good to me, thanks Vince!
Ok, great - I'd suggest a v3 repost with the rename suggested by
Lawrence applied as well, plus with Cyrill's and Lawrence's
Acked-by's included. Then this new hw support patch can go into
the perf tree and if all goes well into the v3.7 kernel.
Thanks,
Ingo
prev parent reply other threads:[~2012-09-26 7:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 16:23 [PATCH V2 1/1] perf, Add support for Xeon-Phi PMU Vince Weaver
2012-09-25 16:26 ` Meadows, Lawrence F
2012-09-25 20:18 ` Cyrill Gorcunov
2012-09-26 7:56 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120926075610.GB2013@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=eranian@gmail.com \
--cc=gorcunov@openvz.org \
--cc=lawrence.f.meadows@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.