From: Theodore Ts'o <tytso@mit.edu>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org, a-fujita@rs.jp.nec.com
Subject: Re: [PATCH 3/4] ext4: basic bug shield for move_extent_per_page
Date: Wed, 26 Sep 2012 12:50:07 -0400 [thread overview]
Message-ID: <20120926165007.GC18983@thunk.org> (raw)
In-Reply-To: <1348489434-22778-4-git-send-email-dmonakhov@openvz.org>
Applied, thanks.
I added one sanity check:
> + for(bh = head, block_start = 0; bh != head || !block_start;
> + block++, block_start = block_end, bh = bh->b_this_page) {
...
BUG_ON(nr >= MAX_BUF_PER_PAGE);
> + arr[nr++] = bh;
> + }
...just to make sure a corrupted link list on b_this_page can't cause
a on-stack array overrun.
- Ted
next prev parent reply other threads:[~2012-09-26 16:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 12:23 [PATCH 0/4] ext4: ioc_move_ext fixes Dmitry Monakhov
2012-09-24 12:23 ` [PATCH 1/4] ext4: move_extent code cleanup Dmitry Monakhov
2012-09-26 16:30 ` Theodore Ts'o
2012-09-24 12:23 ` [PATCH 2/4] ext4: online defrag is not supported for journaled files Dmitry Monakhov
2012-09-26 16:30 ` Theodore Ts'o
2012-09-24 12:23 ` [PATCH 3/4] ext4: basic bug shield for move_extent_per_page Dmitry Monakhov
2012-09-26 16:50 ` Theodore Ts'o [this message]
2012-09-24 12:23 ` [PATCH 4/4] ext4: reimplement uninit extent optimization for move_extent_per_page V2 Dmitry Monakhov
2012-09-26 16:56 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120926165007.GC18983@thunk.org \
--to=tytso@mit.edu \
--cc=a-fujita@rs.jp.nec.com \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.