From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprog: remove duplicate vector memalign from xfs_io
Date: Thu, 27 Sep 2012 10:00:24 +1000 [thread overview]
Message-ID: <20120927000024.GA15236@dastard> (raw)
In-Reply-To: <20120925142421.398175185@sgi.com>
On Tue, Sep 25, 2012 at 09:24:15AM -0500, Mark Tinguely wrote:
> The vector feature of xfs_io uses its own memory buffer in the iov structure
> and does not use the buffer entry. Remove the duplicate memalign.
>
> Signed-off-by: Mark Tinguely <tinguely@sgi.com>
> ---
> io/pread.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: b/io/pread.c
> ===================================================================
> --- a/io/pread.c
> +++ b/io/pread.c
> @@ -76,8 +76,7 @@ alloc_iovec(
> buffersize = 0;
> for (i = 0; i < vectors; i++) {
> iov[i].iov_base = memalign(pagesize, bsize);
> - buffer = memalign(pagesize, bsize);
> - if (!buffer) {
> + if (!iov[i].iov_base) {
> perror("memalign");
> goto unwind;
> }
Classic copy'n'paste bug. My fault.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-09-26 23:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120925142414.660506845@sgi.com>
2012-09-25 14:24 ` [PATCH] xfsprog: remove duplicate vector memalign from xfs_io Mark Tinguely
2012-09-26 22:04 ` Ben Myers
2012-09-26 22:21 ` Mark Tinguely
2012-09-27 0:01 ` Dave Chinner
2012-09-27 14:59 ` Ben Myers
2012-09-27 12:47 ` [PATCH v2] " Mark Tinguely
2012-09-27 15:05 ` Ben Myers
2012-09-27 22:52 ` Dave Chinner
2012-09-28 16:38 ` Mark Tinguely
2012-09-27 0:00 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927000024.GA15236@dastard \
--to=david@fromorbit.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.