From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: drivers/staging/comedi/drivers/ni_pcimio.c:1694 pcimio_attach_pci() warn: 'dev->irq' was not release
Date: Thu, 27 Sep 2012 00:54:32 +0000 [thread overview]
Message-ID: <20120927005432.GA7205@localhost> (raw)
Hi Bill, Ian,
FYI, this smatch warning probably exists from day 0 of the driver
code:
+ drivers/staging/comedi/drivers/ni_pcimio.c:1694 pcimio_attach_pci() warn: 'dev->irq' was not released on error
vim +1694 drivers/staging/comedi/drivers/ni_pcimio.c
1678 dev->irq = mite_irq(devpriv->mite);
1679
1680 if (dev->irq = 0) {
1681 pr_warn("unknown irq (bad)\n");
1682 } else {
1683 pr_debug("( irq = %u )\n", dev->irq);
1684 ret = request_irq(dev->irq, ni_E_interrupt, NI_E_IRQ_FLAGS,
1685 DRV_NAME, dev);
1686 if (ret < 0) {
1687 pr_warn("irq not available\n");
1688 dev->irq = 0;
1689 }
1690 }
1691
1692 ret = ni_E_init(dev);
1693 if (ret < 0)
> 1694 return ret;
1695
1696 dev->subdevices[NI_AI_SUBDEV].buf_change = &pcimio_ai_change;
1697 dev->subdevices[NI_AO_SUBDEV].buf_change = &pcimio_ao_change;
1698 dev->subdevices[NI_GPCT_SUBDEV(0)].buf_change = &pcimio_gpct0_change;
1699 dev->subdevices[NI_GPCT_SUBDEV(1)].buf_change = &pcimio_gpct1_change;
1700 dev->subdevices[NI_DIO_SUBDEV].buf_change = &pcimio_dio_change;
1701
1702 return ret;
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation
next reply other threads:[~2012-09-27 0:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 0:54 Fengguang Wu [this message]
2012-09-27 9:46 ` drivers/staging/comedi/drivers/ni_pcimio.c:1694 pcimio_attach_pci() warn: 'dev->irq' was not rel Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927005432.GA7205@localhost \
--to=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.