From: Robert Love <robert.w.love@intel.com>
To: cleech@redhat.com, bvanassche@acm.org, bprakash@broadcom.com
Cc: devel@open-fcoe.org, linux-scsi@vger.kernel.org
Subject: [RFC PATCH v2 2/5] libfcoe: Add fcoe_sysfs debug logging level
Date: Wed, 26 Sep 2012 19:01:53 -0700 [thread overview]
Message-ID: <20120927020153.20592.10023.stgit@fritz> (raw)
In-Reply-To: <20120927020142.20592.56661.stgit@fritz>
Add a macro to print fcoe_sysfs debug statements.
Signed-off-by: Robert Love <robert.w.love@intel.com>
---
drivers/scsi/fcoe/fcoe_sysfs.c | 7 +++++++
drivers/scsi/fcoe/libfcoe.h | 11 ++++++++---
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/fcoe/fcoe_sysfs.c b/drivers/scsi/fcoe/fcoe_sysfs.c
index 2bc1631..f207bbd 100644
--- a/drivers/scsi/fcoe/fcoe_sysfs.c
+++ b/drivers/scsi/fcoe/fcoe_sysfs.c
@@ -24,6 +24,13 @@
#include <scsi/fcoe_sysfs.h>
+/*
+ * OK to include local libfcoe.h for debug_logging, but cannot include
+ * <scsi/libfcoe.h> otherwise non-netdev based fcoe solutions would have
+ * have to include more than fcoe_sysfs.h.
+ */
+#include "libfcoe.h"
+
static atomic_t ctlr_num;
static atomic_t fcf_num;
diff --git a/drivers/scsi/fcoe/libfcoe.h b/drivers/scsi/fcoe/libfcoe.h
index 3a758c2..d3bb16d 100644
--- a/drivers/scsi/fcoe/libfcoe.h
+++ b/drivers/scsi/fcoe/libfcoe.h
@@ -2,9 +2,10 @@
#define _FCOE_LIBFCOE_H_
extern unsigned int libfcoe_debug_logging;
-#define LIBFCOE_LOGGING 0x01 /* General logging, not categorized */
-#define LIBFCOE_FIP_LOGGING 0x02 /* FIP logging */
-#define LIBFCOE_TRANSPORT_LOGGING 0x04 /* FCoE transport logging */
+#define LIBFCOE_LOGGING 0x01 /* General logging, not categorized */
+#define LIBFCOE_FIP_LOGGING 0x02 /* FIP logging */
+#define LIBFCOE_TRANSPORT_LOGGING 0x04 /* FCoE transport logging */
+#define LIBFCOE_SYSFS_LOGGING 0x08 /* fcoe_sysfs logging */
#define LIBFCOE_CHECK_LOGGING(LEVEL, CMD) \
do { \
@@ -27,4 +28,8 @@ do { \
LIBFCOE_CHECK_LOGGING(LIBFCOE_TRANSPORT_LOGGING, \
pr_info("%s: " fmt, __func__, ##args);)
+#define LIBFCOE_SYSFS_DBG(cdev, fmt, args...) \
+ LIBFCOE_CHECK_LOGGING(LIBFCOE_SYSFS_LOGGING, \
+ pr_info("ctlr_%d: " fmt, cdev->id, ##args);)
+
#endif /* _FCOE_LIBFCOE_H_ */
next prev parent reply other threads:[~2012-09-27 2:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 2:01 [RFC PATCH v2 0/5] Add new fcoe_sysfs based control interfaces to libfcoe, bnx2fc and fcoe Robert Love
2012-09-27 2:01 ` [RFC PATCH v2 1/5] fix_section_mismatch Robert Love
2012-09-27 2:01 ` Robert Love [this message]
2012-09-27 2:01 ` [RFC PATCH v2 3/5] libfcoe, fcoe, bnx2fc: Add new fcoe control interface Robert Love
2012-09-30 16:42 ` Bart Van Assche
2012-09-27 2:02 ` [RFC PATCH v2 4/5] fcoe: Use the fcoe_sysfs " Robert Love
2012-09-27 2:02 ` [RFC PATCH v2 5/5] bnx2fc: " Robert Love
2012-10-01 6:49 ` Bhanu Prakash Gollapudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927020153.20592.10023.stgit@fritz \
--to=robert.w.love@intel.com \
--cc=bprakash@broadcom.com \
--cc=bvanassche@acm.org \
--cc=cleech@redhat.com \
--cc=devel@open-fcoe.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.