From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: use adjusted_mode instead of mode
 for checking the 6bpc force flag
Date: Thu, 27 Sep 2012 08:42:56 +0200
Message-ID: <20120927064256.GQ1980@bremse>
References: <1348673271-23891-1-git-send-email-jani.nikula@intel.com>
	<1348674190-16908-1-git-send-email-jani.nikula@intel.com>
	<1348674636.4244.26.camel@atropine>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-la0-f49.google.com (mail-la0-f49.google.com
	[209.85.215.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id F408F9F390
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 26 Sep 2012 23:43:01 -0700 (PDT)
Received: by lagz14 with SMTP id z14so295206lag.36
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 26 Sep 2012 23:43:01 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1348674636.4244.26.camel@atropine>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Adam Jackson <ajax@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org, stable@vger.kernel.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Sep 26, 2012 at 11:50:36AM -0400, Adam Jackson wrote:
> On Wed, 2012-09-26 at 18:43 +0300, Jani Nikula wrote:
> > The dithering introduced in
> > 
> > commit 3b5c78a35cf7511c15e09a9b0ffab290a42d9bcf
> > Author: Adam Jackson <ajax@redhat.com>
> > Date:   Tue Dec 13 15:41:00 2011 -0800
> > 
> >     drm/i915/dp: Dither down to 6bpc if it makes the mode fit
> > 
> > stores the INTEL_MODE_DP_FORCE_6BPC flag in the private_flags of the
> > adjusted mode, while i9xx_crtc_mode_set() and ironlake_crtc_mode_set() use
> > the original mode, without the flag, so it would never have any
> > effect. However, the BPC was clamped by VBT settings, making things work by
> > coincidence, until that part was removed in
> > 
> > commit 4344b813f105a19f793f1fd93ad775b784648b95
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date:   Fri Aug 10 11:10:20 2012 +0200
> > 
> > Use adjusted_mode instead of mode when checking for
> > INTEL_MODE_DP_FORCE_6BPC to make the flag have effect.
> > 
> > v2: Don't forget to fix this in i9xx_crtc_mode_set() also, pointed out by
> > Daniel both before and after sending the first patch.
> 
> Reviewed-by: Adam Jackson <ajax@redhat.com>
Picked up for -fixes, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch