From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: sameo@linux.intel.com, marex@denx.de,
ashish.jangam@kpitcummins.com, dchen@diasemi.com,
linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] mfd: da9052-core: Fix request_threaded_irq() parameter
Date: Thu, 27 Sep 2012 15:08:44 +0100 [thread overview]
Message-ID: <20120927140843.GX4428@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1348718135-10300-1-git-send-email-festevam@gmail.com>
On Thu, Sep 27, 2012 at 12:55:35AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> On a mx53qsb dt-kernel the da9052-core driver fails to probe:
>
> da9052 1-0048: DA9052 ADC IRQ failed ret=-22
>
> In request_threaded_irq() the first parameter is missing the da9052->irq_base.
>
> Fix it and avoid the error.
The driver shouldn't be relying on irq_base at all, it should use
regmap_get_virq() to look up the interrupt number. If it relies on
irq_base then the user is forced to assign one (or rely on automatic
assignment, which is a bit erratic. Otherwise it can use a linear
domain which doesn't rely on being able to allocate a big block of
interrupt numbers.
next prev parent reply other threads:[~2012-09-27 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 3:55 [PATCH] mfd: da9052-core: Fix request_threaded_irq() parameter Fabio Estevam
2012-09-27 13:21 ` Marek Vasut
2012-09-27 14:08 ` Mark Brown [this message]
2012-09-27 14:34 ` Arnd Bergmann
2012-09-27 16:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927140843.GX4428@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ashish.jangam@kpitcummins.com \
--cc=dchen@diasemi.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.