All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: Powering OMAP's pins
Date: Thu, 27 Sep 2012 11:43:41 -0700	[thread overview]
Message-ID: <20120927184341.GK4840@atomide.com> (raw)
In-Reply-To: <1348730334.5559.9.camel@lappyti>

* Tomi Valkeinen <tomi.valkeinen@ti.com> [120927 00:20]:
> On Wed, 2012-09-26 at 11:59 -0700, Tony Lindgren wrote:
> > * Tomi Valkeinen <tomi.valkeinen@ti.com> [120926 00:06]:
> 
> > > So if I want to use parallel dss output, which uses dss_data0 pin,
> > > omapdss driver needs to enable vdda_dsi on omap3430, even though there's
> > > no other use for vdda_dsi in the parallel output case. But on omap4430
> > > data0 pins seems to be powered by vdds_1p8v. On AM35xx something else.
> > > So either I need to program all those into the omapdss driver, which is
> > > not the right way as they are platform specific things, or I need to
> > > pass some kind of pin data from platform data to omapdss driver, giving
> > > the required regulator for each pin.
> > 
> > Pass the device tree regulators to the DSS driver and enable the
> > ones with runtime PM in the DSS driver? I guess you have the names
> > for those regulatros?
> 
> Well, yes, I could create a pin->regulator mapping for dss that is
> filled in the DT data.

OK, that's probably the way to go as we don't have any other place
for that mapping.
 
> I just feel this is something that the omapdss driver shouldn't care
> about. The powers for the pins are in no way related to dss.

OK, maybe some of this can be done automatically later.
 
> > > And how about the uart1_cts or gpio_70 pins on 3430? Do both uart and
> > > gpio drivers need to have similar kind of platform data, giving the
> > > required regulator so that the pin can be enabled?
> > 
> > Hmm aren't those always enabled with VIO_18?
> 
> No, 3430 datamanual (OMAP34xx_ES2.0_ES2.1_POP_DM_V_K.pdf) says some uart
> and gpio pins are powered by vdds_dsi, some by vdds_sdi, some gpio pins
> are powered by vdds_csi2, etc.

OK. I guess these pins are rarely used in the alternative mux
modes as it has not been much of a problem so far.

> I could be mistaken how to HW works (but it does work like that for
> dss), but sounds to me that uart and gpio drivers (and perhaps some
> others, I didn't go through all the pins) need similar pin->regulator
> mapping as you suggested for omapdss.

Yes it seems that there are supply voltage regulator domains
that are specific to some subsystems. I wonder if these are needed
in all mux modes, or only when the pins are muxed for that particular
subsystem? It could be that the documentation is missing some
information here..

For example, what happens if you try to use some vdds_dsi powered
pin in GPIO mode without vdds_dsi?

Regards,

Tony

  reply	other threads:[~2012-09-27 18:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-25 10:21 Powering OMAP's pins Tomi Valkeinen
2012-09-25 15:38 ` Tony Lindgren
2012-09-25 17:05   ` Tomi Valkeinen
2012-09-25 19:07     ` Tony Lindgren
2012-09-26  7:05       ` Tomi Valkeinen
2012-09-26 18:59         ` Tony Lindgren
2012-09-27  7:18           ` Tomi Valkeinen
2012-09-27 18:43             ` Tony Lindgren [this message]
2012-09-27 18:51               ` Tony Lindgren
2012-09-28  6:13                 ` Tomi Valkeinen
2012-09-28 14:37                   ` Tony Lindgren
2012-09-26 11:46     ` Linus Walleij
2012-09-26 12:56       ` Tomi Valkeinen
2012-09-26 13:27         ` Linus Walleij
2012-09-26 19:03           ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120927184341.GK4840@atomide.com \
    --to=tony@atomide.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.