From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v2 2/7] libibverbs: libibverbs: Introduce XRC domains Date: Thu, 27 Sep 2012 18:34:27 -0600 Message-ID: <20120928003427.GA21759@obsidianresearch.com> References: <1828884A29C6694DAF28B7E6B8A8237346A97DD6@FMSMSX151.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1828884A29C6694DAF28B7E6B8A8237346A97DD6-Q3cL8pyY+6ukrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Hefty, Sean" Cc: "linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)" , "miked-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" , "Tzahi Oved (tzahio-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org)" , Roland Dreier , "yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Fri, Sep 28, 2012 at 12:02:39AM +0000, Hefty, Sean wrote: > +enum verbs_xrcd_mask { > + VERBS_XRCD_HANDLE = 1 << 0, > + VERBS_XRCD_RESERVED = 1 << 1 > +}; I think it would be a good idea to make both of these constants (1<<0), the '0' serves as an ABI rev, not an individual field. That will give a bit more life to this system, and it makes much more sense to require them be present as a group. Same comment for all the comp_masks you introduced. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html