Re: [PATCH] mdadm: autodetect being run in an initramfs

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]

On Thu, 27 Sep 2012 10:41:03 -0400 Dave Reisner <dreisner@archlinux.org>
wrote:

> Key off of the existance of /etc/initrd-release as an indicator that
> mdadm is running in early userspace and set the __offroot flag. This
> allows the same udev-based assembly rules to be valid both off and on
> root and, moreover, will propagate to mdmon, should it need to be
> started.
> 
> Signed-off-by: Dave Reisner <dreisner@archlinux.org>
> ---
>  mdadm.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/mdadm.c b/mdadm.c
> index 4c7c5ea..557e00b 100644
> --- a/mdadm.c
> +++ b/mdadm.c
> @@ -1106,6 +1106,11 @@ int main(int argc, char *argv[])
>  		exit(0);
>  	}
>  
> +	/* auto-detect being on an initramfs
> +	 * http://www.freedesktop.org/wiki/Software/systemd/InitrdInterface */
> +	if (access("/etc/initrd-release", F_OK) == 0)
> +		__offroot = 1;
> +
>  	if (!mode && devs_found) {
>  		mode = MISC;
>  		devmode = 'Q';

What is the problem with adding the --offroot flag to every place in the
initrd that starts mdadm?

(Actually I'm contemplating making --offroot the default so this might become
a non-issue)

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]