From: Johan Hedberg <johan.hedberg@gmail.com>
To: chen.ganir@ti.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v4 01/10] battery: Add generic device battery documentation
Date: Fri, 28 Sep 2012 13:59:37 +0300 [thread overview]
Message-ID: <20120928105937.GA14450@x220> (raw)
In-Reply-To: <1348470919-25567-2-git-send-email-chen.ganir@ti.com>
Hi Chen,
On Mon, Sep 24, 2012, chen.ganir@ti.com wrote:
> +BlueZ D-Bus Battery API description
> +****************************************
Please keep the "underline" consistent with the length of the text above
it.
> + Texas Instruments, Inc. <chen.ganir@ti.com>
What's this supposed to be? If you want a copyright statement here then
make it of the proper format. Author info is not needed as we have the
AUTHORS file and the commit history.
> +Device Battery hierarchy
> +=====================================
Same thing with the consistency of the "underline"
> +Service org.bluez
> +Interface org.bluez.Battery
> +Object path [variable prefix]/{hci0,..}/dev_XX_XX_XX_XX_XX_XX/BATTYYYY
> +YYYY is numeric value between 0 and 9999.
I don't think you need a separate comment for the "YYY". We don't have
that for the "XX" stuff either.
> + array{object} Batteries [readonly]
I guess you should mark this with [experimental] since it'll be removed
with the advent of ObjectManager.
Johan
next prev parent reply other threads:[~2012-09-28 10:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 7:15 [PATCH v4 00/10] Implement Generic battery and LE Battery client chen.ganir
2012-09-24 7:15 ` [PATCH v4 01/10] battery: Add generic device battery documentation chen.ganir
2012-09-28 10:59 ` Johan Hedberg [this message]
2012-09-30 6:57 ` Chen Ganir
2012-09-30 10:56 ` Johan Hedberg
2012-09-24 7:15 ` [PATCH v4 02/10] battery: Implement Generic device battery chen.ganir
2012-09-24 7:15 ` [PATCH v4 03/10] battery: Add GATT Battery Client Service skeleton chen.ganir
2012-09-24 7:15 ` [PATCH v4 04/10] battery: Add client connection logic chen.ganir
2012-09-24 7:15 ` [PATCH v4 05/10] battery: Discover Characteristic Descriptors chen.ganir
2012-09-24 7:15 ` [PATCH v4 06/10] battery: Get Battery ID chen.ganir
2012-09-24 7:15 ` [PATCH v4 07/10] battery: Add Battery to device chen.ganir
2012-09-24 7:15 ` [PATCH v4 08/10] battery: Read Battery level characteristic chen.ganir
2012-09-24 7:15 ` [PATCH v4 09/10] battery: Add support for notifications chen.ganir
2012-09-24 7:15 ` [PATCH v4 10/10] battery: Support persistent battery level chen.ganir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928105937.GA14450@x220 \
--to=johan.hedberg@gmail.com \
--cc=chen.ganir@ti.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.