From: Dan Carpenter <dan.carpenter@oracle.com>
To: smani@micron.com
Cc: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Subject: re: mtip32xx:Added appropriate timeout value for secure erase
Date: Fri, 28 Sep 2012 15:25:31 +0300 [thread overview]
Message-ID: <20120928122531.GA9260@elgon.mountain> (raw)
Hello Selvan Mani,
The patch 75e152877069: "mtip32xx:Added appropriate timeout value for
secure erase" from Sep 27, 2012, leads to the following warning:
drivers/block/mtip32xx/mtip32xx.c:2222 exec_drive_taskfile()
error: potential NULL dereference 'outbuf'.
2220 /* check for erase mode support during secure erase.*/
2221 if ((fis.command == ATA_CMD_SEC_ERASE_UNIT)
2222 && (outbuf[0] & MTIP_SEC_ERASE_MODE)) {
^^^^^^
Smatch complains that if taskout is zero this is a NULL dereference.
Obviously that's not normal, but it looks like it might be possible.
2223 erasemode = 1;
2224 }
regards,
dan carpenter
next reply other threads:[~2012-09-28 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 12:25 Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-09-27 12:57 mtip32xx:Added appropriate timeout value for secure erase Selvan Mani
2012-09-27 12:37 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928122531.GA9260@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=smani@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.