From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [PATCH] drm: call connector->dpms(OFF) when disabling Date: Fri, 28 Sep 2012 13:52:02 +0100 Message-ID: <20120928135202.31ee4850@pyramind.ukuu.org.uk> References: <1348817238-30228-1-git-send-email-rob.clark@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from lxorguk.ukuu.org.uk (lxorguk.ukuu.org.uk [81.2.110.251]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F513A0DA0 for ; Fri, 28 Sep 2012 05:47:05 -0700 (PDT) In-Reply-To: <1348817238-30228-1-git-send-email-rob.clark@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Rob Clark Cc: Rob Clark , patches@linaro.org, dri-devel@lists.freedesktop.org, rogerq@ti.com List-Id: dri-devel@lists.freedesktop.org On Fri, 28 Sep 2012 09:27:18 +0200 Rob Clark wrote: > From: Rob Clark > > When disabling unused connectors, be sure to call connector->dpms(OFF), > so if there is actually some IP to turn off (such as external bridge > chips, etc), these actually do get turned off. That's a fairly drastic and non-obvious API change for all the other drivers. Have you tested this widely on other hardware ? Alan