From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758746Ab2I1WTh (ORCPT <rfc822;w@1wt.eu>);
	Fri, 28 Sep 2012 18:19:37 -0400
Received: from bhuna.collabora.co.uk ([93.93.135.160]:42413 "EHLO
	bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758465Ab2I1WTf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 28 Sep 2012 18:19:35 -0400
Date: Fri, 28 Sep 2012 19:19:27 -0300
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        alan@lxorguk.ukuu.org.uk,
        Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
Subject: Re: [ 056/127] Bluetooth: Fix not removing power_off delayed work
Message-ID: <20120928221927.GC15454@joana>
References: <20120928203045.835238916@linuxfoundation.org>
 <20120928203052.382739768@linuxfoundation.org>
 <1348870383.6858.5.camel@deadeye.wl.decadent.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1348870383.6858.5.camel@deadeye.wl.decadent.org.uk>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Ben Hutchings <ben@decadent.org.uk> [2012-09-29 00:13:03 +0200]:

> On Fri, 2012-09-28 at 13:33 -0700, Greg Kroah-Hartman wrote:
> > 3.0-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
> > 
> > commit 78c04c0bf52360dc2f7185e99c8e9aa05d73ae5a upstream.
> > 
> > For example, when a usb reset is received (I could reproduce it
> > running something very similar to this[1] in a loop) it could be
> > that the device is unregistered while the power_off delayed work
> > is still scheduled to run.
> [...]
> > --- a/net/bluetooth/hci_core.c
> > +++ b/net/bluetooth/hci_core.c
> > @@ -588,6 +588,8 @@ static int hci_dev_do_close(struct hci_d
> >  {
> >  	BT_DBG("%s %p", hdev->name, hdev);
> >  
> > +	cancel_delayed_work(&hdev->power_off);
> [...]
> 
> This is not right for 3.0 as the type of hdev->power_off is struct
> work_struct, not struct delayed_work.
> 
> When I looked at this for 3.2 it appeared that this fix might not be
> required at all.

Yes, at that time we had a timer to run the work, at some point we changed it
with a delayed_work but I don't remember exactly which version was it, 3.3 I
think.

	Gustavo