From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965092Ab2I1XwN (ORCPT ); Fri, 28 Sep 2012 19:52:13 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:32885 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964876Ab2I1XwL (ORCPT ); Fri, 28 Sep 2012 19:52:11 -0400 X-Sasl-enc: 7epoho7dfS2xV+MBoTIl5eLLqnSkKfP9jVf5IjrF/VMq 1348876330 Date: Fri, 28 Sep 2012 16:52:09 -0700 From: "gregkh@linuxfoundation.org" To: Ramesh Nagappa Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "davem@davemloft.net" , "michel@digirati.com.br" , "eric.dumazet@gmail.com" Subject: Re: [PATCH] net: fix neigh_resolve_output can cause skb_under_panic Message-ID: <20120928235209.GA11474@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 28, 2012 at 07:40:39PM -0400, Ramesh Nagappa wrote: > >From fd023edd911ef12aca38a72b40241661c202684f Mon Sep 17 00:00:00 2001 > From: Ramesh Nagappa > Date: Thu, 27 Sep 2012 10:20:58 -0700 > Subject: [PATCH] net: fix neigh_resolve_output can cause skb_under_panic Why is all of this in the middle of the changelog section? I'm guessing you didn't use 'git send-email' for this? And why are you copying me on the patch? > The retry loop in the neigh_resolve_output() and neigh_connected_output() can add > a hard_header without resetting the skb to network header. This causes the > skb_push() in dev_hard_header() to fail. > Signed-off-by: Ramesh Nagappa > Signed-off-by: Shawn Lu > Reviewed-by: Billie Alsup > Reviewed-by: Robert Coulson You need a blank line before the first Signed-off-by: line. Surely one of the reviewers should have caught this basic thing? greg k-h