From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030429Ab2I2A51 (ORCPT ); Fri, 28 Sep 2012 20:57:27 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:51489 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759289Ab2I2A5X (ORCPT ); Fri, 28 Sep 2012 20:57:23 -0400 X-Sasl-enc: 0RuL8K0f08ndOMxs6sYdCeYYIrLUbKY7NzGelfEV18+C 1348880242 Date: Fri, 28 Sep 2012 17:57:21 -0700 From: "gregkh@linuxfoundation.org" To: Ramesh Nagappa Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "davem@davemloft.net" , "michel@digirati.com.br" , "eric.dumazet@gmail.com" Subject: Re: [PATCH] net: fix neigh_resolve_output can cause skb_under_panic Message-ID: <20120929005721.GA13335@kroah.com> References: <20120928235209.GA11474@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 28, 2012 at 08:26:51PM -0400, Ramesh Nagappa wrote: > > > > Why is all of this in the middle of the changelog section? > > > > I'm guessing you didn't use 'git send-email' for this? > > > > And why are you copying me on the patch? > > I got the CC list from scripts/get_maintainers.pl > > asglx-2-300 $ scripts/get_maintainer.pl 0001-net-fix-neigh_resolve_output-can-cause-skb_under_pan.patch > "David S. Miller" (maintainer:NETWORKING [GENERAL],commit_signer:3/4=75%) > Greg Kroah-Hartman (commit_signer:3/4=75%) > Eric Dumazet (commit_signer:2/4=50%) > Shawn Lu (commit_signer:1/4=25%) > Michel Machado (commit_signer:1/4=25%) > netdev@vger.kernel.org (open list:NETWORKING [GENERAL]) > linux-kernel@vger.kernel.org (open list) I can't reproduce this: $ ./scripts/get_maintainer.pl --file net/core/neighbour.c "David S. Miller" (maintainer:NETWORKING [GENERAL],commit_signer:22/22=100%) Eric Dumazet (commit_signer:4/22=18%) "Eric W. Biederman" (commit_signer:2/22=9%) Pavel Emelyanov (commit_signer:2/22=9%) netdev@vger.kernel.org (open list:NETWORKING [GENERAL]) linux-kernel@vger.kernel.org (open list) What tree are you doing that against? > > You need a blank line before the first Signed-off-by: line. > > Surely one of the reviewers should have caught this basic thing? > > Outlook mangled the patch. I am unable to use git send-email because of > a corporate firewall on the build machine. Then your patch would also be corrupted, Outlook, and Exchange, can not handle patches at all. Please read Documentation/email_clients.txt for more details. Also, ask your coworkers who properly submit patches what they do to work around your broken email infrastructure. good luck, greg k-h