From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932191Ab2I2IeK (ORCPT ); Sat, 29 Sep 2012 04:34:10 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:64519 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755411Ab2I2IeG (ORCPT ); Sat, 29 Sep 2012 04:34:06 -0400 Date: Sat, 29 Sep 2012 10:34:00 +0200 From: Ingo Molnar To: Jean Delvare , linux-kernel@vger.kernel.org, x86@kernel.org, Michal Marek , Ralf Baechle Subject: Re: [PATCH] kbuild: Fix gcc -x syntax Message-ID: <20120929083400.GA8122@gmail.com> References: <1348859536.22956.4.camel@amber.site> <20120929073749.GA7672@gmail.com> <20120929082459.GA10005@brahe.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120929082459.GA10005@brahe.fritz.box> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Bernhard Walle wrote: > Hi, > > * Ingo Molnar [2012-09-29 08:37]: > > * Jean Delvare wrote: > > > > > The correct syntax for gcc -x is "gcc -x assembler", not "gcc > > > -xassembler". Even though the latter happens to work, the > > > former is what is documented in the manual page and thus what > > > gcc wrappers such as icecream do expect. > > > > > > This isn't a cosmetic change. The missing space prevents > > > icecream from recognizing compilation tasks it can't handle, > > > leading to silent kernel miscompilations. > > > > Although we can apply this patch, it won't solve the problem of > > building older kernels (and bisecting, etc.). > > > > Wouldn't it be prudent to increase the compatibility of > > icecream, so that it accepts what GCC accepts in practice, > > such as -xassembler? > > Wouldn't it make sense to do both? Using the documented syntax > in the build system *and* increase compatibility in 3rd party > tools? Yes. Thanks, Ingo