diff for duplicates of <20120929143205.GN4587@mwanda> diff --git a/a/1.txt b/N1/1.txt index 312e590..89c8c74 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -17,10 +17,11 @@ On Sat, Sep 29, 2012 at 12:52:38PM +0200, walter harms wrote: > > } > > > > /* Default if filename is empty string */ -> > - if (strcmp(dev->input_filename, "") = 0) { -> > + if (strcmp(dev->_filename, "") = 0) { +> > - if (strcmp(dev->input_filename, "") == 0) { +> > + if (strcmp(dev->_filename, "") == 0) { > > if (dev->_isNTSC) { -> > dev->_filename > > (dev->_pixel_format = PIXEL_FRMT_411) ? +> > dev->_filename = +> > (dev->_pixel_format == PIXEL_FRMT_411) ? > > diff --git a/drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c b/drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c > > index c8c94fb..d33fc1a 100644 > > --- a/drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c @@ -29,15 +30,15 @@ On Sat, Sep 29, 2012 at 12:52:38PM +0200, walter harms wrote: > > } > > > > /* Default if filename is empty string */ -> > - if (strcmp(dev->input_filename_ch2, "") = 0) { -> > + if (strcmp(dev->_filename_ch2, "") = 0) { +> > - if (strcmp(dev->input_filename_ch2, "") == 0) { +> > + if (strcmp(dev->_filename_ch2, "") == 0) { > > if (dev->_isNTSC_ch2) { -> > dev->_filename_ch2 = (dev->_pixel_format_ch2 = +> > dev->_filename_ch2 = (dev->_pixel_format_ch2 == > > PIXEL_FRMT_411) ? "/root/vid411.yuv" : > > > > In this case stcmp seems a bit of a overkill. A simple -> *(dev->_filename_ch2) = 0 +> *(dev->_filename_ch2) == 0 > should be ok ? I prefer strcmp() actually. More readable. diff --git a/a/content_digest b/N1/content_digest index e16df92..b6aab2a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\05066D2F6.10800@bfs.de\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [patch] [media] cx25821: testing the wrong variable\0" - "Date\0Sat, 29 Sep 2012 14:32:05 +0000\0" + "Date\0Sat, 29 Sep 2012 17:32:05 +0300\0" "To\0walter harms <wharms@bfs.de>\0" "Cc\0Mauro Carvalho Chehab <mchehab@infradead.org>" Leonid V. Fedorenchik <leonidsbox@gmail.com> @@ -31,10 +31,11 @@ "> > \t}\n" "> > \n" "> > \t/* Default if filename is empty string */\n" - "> > -\tif (strcmp(dev->input_filename, \"\") = 0) {\n" - "> > +\tif (strcmp(dev->_filename, \"\") = 0) {\n" + "> > -\tif (strcmp(dev->input_filename, \"\") == 0) {\n" + "> > +\tif (strcmp(dev->_filename, \"\") == 0) {\n" "> > \t\tif (dev->_isNTSC) {\n" - "> > \t\t\tdev->_filename > > \t\t\t\t(dev->_pixel_format = PIXEL_FRMT_411) ?\n" + "> > \t\t\tdev->_filename =\n" + "> > \t\t\t\t(dev->_pixel_format == PIXEL_FRMT_411) ?\n" "> > diff --git a/drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c b/drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c\n" "> > index c8c94fb..d33fc1a 100644\n" "> > --- a/drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c\n" @@ -43,15 +44,15 @@ "> > \t}\n" "> > \n" "> > \t/* Default if filename is empty string */\n" - "> > -\tif (strcmp(dev->input_filename_ch2, \"\") = 0) {\n" - "> > +\tif (strcmp(dev->_filename_ch2, \"\") = 0) {\n" + "> > -\tif (strcmp(dev->input_filename_ch2, \"\") == 0) {\n" + "> > +\tif (strcmp(dev->_filename_ch2, \"\") == 0) {\n" "> > \t\tif (dev->_isNTSC_ch2) {\n" - "> > \t\t\tdev->_filename_ch2 = (dev->_pixel_format_ch2 =\n" + "> > \t\t\tdev->_filename_ch2 = (dev->_pixel_format_ch2 ==\n" "> > \t\t\t\tPIXEL_FRMT_411) ? \"/root/vid411.yuv\" :\n" "> >\n" "> \n" "> In this case stcmp seems a bit of a overkill. A simple\n" - "> *(dev->_filename_ch2) = 0\n" + "> *(dev->_filename_ch2) == 0\n" "> should be ok ?\n" "\n" "I prefer strcmp() actually. More readable.\n" @@ -67,4 +68,4 @@ "> the body of a message to majordomo@vger.kernel.org\n" > More majordomo info at http://vger.kernel.org/majordomo-info.html -05a4de19e84fe53b50385a402cd1ce816deb5ab12860c618dddcb3a50fbaf18c +2ab539f3ab23a959343f45f1834046e6a99a25c9926ab77ae5e4c512cd5c66c6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.