From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 06/17] iptables: fix order of internal commands list
Date: Mon, 1 Oct 2012 00:13:19 +0200 [thread overview]
Message-ID: <20120930221319.GA18227@1984> (raw)
In-Reply-To: <alpine.LNX.2.01.1209302313540.28050@nerf07.vanv.qr>
On Sun, Sep 30, 2012 at 11:25:42PM +0200, Jan Engelhardt wrote:
>
> On Sunday 2012-09-30 23:09, Pablo Neira Ayuso wrote:
> >On Sun, Sep 30, 2012 at 12:22:09PM +0200, Jan Engelhardt wrote:
> >> Specifying -S on the command line would add 4096 (0x1000, 1<<12) to the
> >> cmd flags, but -S was in fact commands_v_options[13]. This led to a
> >> bogus option checking and an error message:
> >>
> >> $ iptables -A foo -S
> >> iptables v1.4.14: Cannot use -E with -A
> >
> >Are you fixing old bugs?
> >This works here:
> ># iptables -A foo -S
> >iptables v1.4.15: Cannot use -S with -A
>
> Hm.
>
> >http://git.netfilter.org/[...]h=067a9baf6dc82babe466078ab3c05354c7741271
>
> You only changed the "cmdflags" variable so that it lines up with
> the CMD_ flags, however, you forgot to line up "commands_v_options"
> as well.
>
> Indeed your patch 067a9baf fixes "cannot use $that with $that".
> My commit message was wrong, as I was misled by v1.4.14 behavior.
> In fact, I had the real issue written down first. Approximate
> excerpt from the reflog:
>
>
> iptables: fix order of command flags for option parser
>
> Specifying -S on the command line would add 4096 (0x1000, 1<<12) to the
> cmd flags, but -S was in fact commands_v_options[13].
>
> This problem never manifested itself before, because the [8]-[13] mostly
> had the same 'x' pattern. Now, when trying to allow --line-numbers for
> -S, the issue showed itself as --line-numbers was still rejected even
> after swapping 'x' for ' '.
>
> References: http://bugs.debian.org/642173
>
>
> Does that make more sense?
Yes, that log description looks correct to me. Thanks.
next prev parent reply other threads:[~2012-09-30 22:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 10:22 Mostly documentation fixes Jan Engelhardt
2012-09-30 10:22 ` [PATCH 01/17] doc: clean up interpunction in state list for xt_conntrack Jan Engelhardt
2012-09-30 10:22 ` [PATCH 02/17] doc: deduplicate extension descriptions into a new manpage Jan Engelhardt
2012-09-30 10:22 ` [PATCH 03/17] doc: trim "state" manpage and reference conntrack instead Jan Engelhardt
2012-09-30 10:22 ` [PATCH 04/17] doc: have NOTRACK manpage point to CT instead Jan Engelhardt
2012-09-30 10:22 ` [PATCH 05/17] doc: mention iptables-apply in the SEE ALSO sections Jan Engelhardt
2012-09-30 10:22 ` [PATCH 06/17] iptables: fix order of internal commands list Jan Engelhardt
2012-09-30 21:09 ` Pablo Neira Ayuso
2012-09-30 21:25 ` Jan Engelhardt
2012-09-30 22:13 ` Pablo Neira Ayuso [this message]
2012-09-30 10:22 ` [PATCH 07/17] iptables: implement --line-numbers for iptables -S Jan Engelhardt
2012-09-30 10:22 ` [PATCH 08/17] iptables-restore: kill unused -b option Jan Engelhardt
2012-09-30 10:22 ` [PATCH 09/17] doc: rename .8.in files to .8in Jan Engelhardt
2012-09-30 10:22 ` [PATCH 10/17] doc: add package version to all manpages Jan Engelhardt
2012-09-30 10:22 ` [PATCH 11/17] doc: fixup omissions in ip6tables-restore.8 Jan Engelhardt
2012-09-30 10:22 ` [PATCH 12/17] doc: document iptables-restore's -t option Jan Engelhardt
2012-09-30 10:22 ` [PATCH 13/17] doc: document iptables-restore's -v option Jan Engelhardt
2012-09-30 10:22 ` [PATCH 14/17] doc: document iptables-restore's -M option Jan Engelhardt
2012-09-30 10:22 ` [PATCH 15/17] doc: document iptables-restore's -h option Jan Engelhardt
2012-09-30 10:22 ` [PATCH 16/17] doc: name the supported log levels for ipt_LOG Jan Engelhardt
2012-09-30 10:22 ` [PATCH 17/17] src: remove faulty deprecated marker in libipt_LOG source Jan Engelhardt
2012-09-30 21:16 ` Mostly documentation fixes Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120930221319.GA18227@1984 \
--to=pablo@netfilter.org \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.