From: Ingo Molnar <mingo@kernel.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Bernhard Walle <bernhard@bwalle.de>,
Michal Marek <mmarek@suse.cz>, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH v2] kbuild: Fix gcc -x syntax
Date: Mon, 1 Oct 2012 09:27:39 +0200 [thread overview]
Message-ID: <20121001072739.GC17166@gmail.com> (raw)
In-Reply-To: <1348924408.6962.2.camel@amber.site>
* Jean Delvare <jdelvare@suse.de> wrote:
> The correct syntax for gcc -x is "gcc -x assembler", not
> "gcc -xassembler". Even though the latter happens to work, the former
> is what is documented in the manual page and thus what gcc wrappers
> such as icecream do expect.
>
> This isn't a cosmetic change. The missing space prevents icecream from
> recognizing compilation tasks it can't handle, leading to silent kernel
> miscompilations.
>
> Besides me, credits go to Richard Guenther and Dirk Mueller for
> investigating the miscompilation issue and tracking it down to this
> incorrect -x parameter syntax.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: stable@vger.kernel.org
> Cc: Bernhard Walle <bernhard@bwalle.de>
> Cc: Michal Marek <mmarek@suse.cz>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> ---
> Changes since v1:
> * Found more occurrences of the same. These are probably less
> problematic in practice but let's fix them all still.
>
> arch/mips/Makefile | 2 +-
> arch/mips/kernel/Makefile | 2 +-
> arch/x86/Makefile | 2 +-
> scripts/Kbuild.include | 12 ++++++------
> scripts/gcc-version.sh | 6 +++---
> scripts/gcc-x86_32-has-stack-protector.sh | 2 +-
> scripts/gcc-x86_64-has-stack-protector.sh | 2 +-
> scripts/kconfig/check.sh | 2 +-
> scripts/kconfig/lxdialog/check-lxdialog.sh | 2 +-
> tools/perf/Makefile | 2 +-
> tools/power/cpupower/Makefile | 2 +-
> 11 files changed, 18 insertions(+), 18 deletions(-)
Acked-by: Ingo Molnar <mingo@kernel.org>
Michal, want to pick this one up into the kbuild tree?
Thanks,
Ingo
prev parent reply other threads:[~2012-10-01 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-29 13:13 [PATCH v2] kbuild: Fix gcc -x syntax Jean Delvare
2012-10-01 7:27 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121001072739.GC17166@gmail.com \
--to=mingo@kernel.org \
--cc=bernhard@bwalle.de \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=ralf@linux-mips.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.