From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: arm1176: Define arch_cpu_init() for s3c64xx
Date: Mon, 1 Oct 2012 10:56:25 +0200 [thread overview]
Message-ID: <201210011056.25985.marex@denx.de> (raw)
In-Reply-To: <50690989.7020000@gmail.com>
Dear Ashok Kumar Reddy,
> Hi Marek Vasut,
>
> On 30-09-2012 18:51, Marek Vasut wrote:
> > Dear Ashok Kumar Reddy,
> >
> >> Hi Marek Vasut , Hi Stephen Warren
> >>
> >> Please provide comments for the below patch, as i forgot to add you in
> >> cc for below mail.
> >
> > You CC wrong people, CCing Minkyu.
> >
> > Anyway, this doesn't seem right, removing CONFIG_ICACHE_OFF from your
> > config file should have the same impact, right?
>
> CONFIG_ICACHE_OFF is valid for only blackfin as per grep in u-boot code,
> the icache enable is done in arch_cpu_init() for arm1176
Ok, CCing Albert.
> >> Regards,
> >> Ashok
> >>
> >> On 26-09-2012 23:59, Ashok Kumar Reddy wrote:
> >>> From 0de61b9690c5f136ba5d3028be43877ea455d843 Mon Sep 17 00:00:00
> >>> 2001
> >>>
> >>> From: Ashok Kumar Reddy <ashokkourla2000@gmail.com>
> >>> Date: Wed, 26 Sep 2012 23:44:59 +0530
> >>> Subject: [PATCH] ARM: arm1176: Define arch_cpu_init() for s3c64xx
> >>>
> >>> arch_cpu_init() is removed from cpu level to SOC level for arm1176
> >>> in commit 4ea6d6b,the same is done for s3c64xx
> >>>
> >>> Signed-off-by: Ashok Kumar Reddy <ashokkourla2000@gmail.com>
> >>> ---
> >>>
> >>> arch/arm/cpu/arm1176/s3c64xx/Makefile | 2 +-
> >>> arch/arm/cpu/arm1176/s3c64xx/init.c | 26
> >>> ++++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 1
> >>> deletion(-)
> >>> create mode 100644 arch/arm/cpu/arm1176/s3c64xx/init.c
> >>>
> >>> diff --git a/arch/arm/cpu/arm1176/s3c64xx/Makefile
> >>> b/arch/arm/cpu/arm1176/s3c64xx/Makefile index 0785b19..266a073 100644
> >>> --- a/arch/arm/cpu/arm1176/s3c64xx/Makefile
> >>> +++ b/arch/arm/cpu/arm1176/s3c64xx/Makefile
> >>> @@ -31,7 +31,7 @@ LIB = $(obj)lib$(SOC).o
> >>>
> >>> SOBJS = reset.o
> >>>
> >>> COBJS-$(CONFIG_S3C6400) += cpu_init.o speed.o
> >>>
> >>> -COBJS-y += timer.o
> >>> +COBJS-y += timer.o init.o
> >>>
> >>> OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS-y))
> >>>
> >>> diff --git a/arch/arm/cpu/arm1176/s3c64xx/init.c
> >>> b/arch/arm/cpu/arm1176/s3c64xx/init.c new file mode 100644
> >>> index 0000000..f113d8e
> >>> --- /dev/null
> >>> +++ b/arch/arm/cpu/arm1176/s3c64xx/init.c
> >>> @@ -0,0 +1,26 @@
> >>> +/*
> >>> + * (C) Copyright 2012 Ashok Kumar Reddy Kourla
> >>> + * ashokkourla2000 at gmail.com
> >>> + *
> >>> + * See file CREDITS for list of people who contributed to this
> >>> + * project.
> >>> + *
> >>> + * This program is free software; you can redistribute it and/or
> >>> + * modify it under the terms of the GNU General Public License as
> >>> + * published by the Free Software Foundation; either version 2 of
> >>> + * the License, or (at your option) any later version.
> >>> + *
> >>> + * This program is distributed in the hope that it will be useful,
> >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> >>> + * GNU General Public License for more details.
> >>> + */
> >>> +
> >>> +#include<common.h>
> >>> +
> >>> +int arch_cpu_init(void)
> >>> +{
> >>> + icache_enable();
> >>> +
> >>> + return 0;
> >>> +}
> >
> > Best regards,
> > Marek Vasut
>
> Regards,
> Ashok
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-10-01 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 18:29 [U-Boot] [PATCH] ARM: arm1176: Define arch_cpu_init() for s3c64xx Ashok Kumar Reddy
2012-09-30 11:24 ` Ashok Kumar Reddy
2012-09-30 13:21 ` Marek Vasut
2012-10-01 3:10 ` Ashok Kumar Reddy
2012-10-01 8:56 ` Marek Vasut [this message]
2012-10-26 8:14 ` Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210011056.25985.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.