From: Don Zickus <dzickus@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: mailinfo: don't require "text" mime type for attachments
Date: Mon, 1 Oct 2012 09:27:46 -0400 [thread overview]
Message-ID: <20121001132746.GV1969@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1209301458540.11079@i5.linux-foundation.org>
On Sun, Sep 30, 2012 at 03:10:48PM -0700, Linus Torvalds wrote:
> This code goes all the way back to March of 2007, in commit 87ab79923463
> ("builtin-mailinfo.c infrastrcture changes"), and apparently Don used to
> pass random mbox contents to git. However, the pre-decode vs post-decode
> logic really shouldn't matter even for that case, and more importantly, "I
> fed git am crap" is not a valid reason to break *real* patch attachments.
>
> If somebody really cares, and determines that some attachment is binary
> data (by looking at the data, not the MIME-type), the whole attachment
> should be dismissed, rather than fed in random-sized chunks to
> "handle_filter()".
Heh. Years ago when I tried using git as a patch-control-management
system instead of a traditional SCM, I fed my custom git-am script an
internal kernel-mail-archives list to help process the meta data for
patches (acks, nacks, needinfo, bugzillas, etc). It served its purpose
until we switched to a fork'd copy of patch-work.
So I haven't done 'insane' stuff in years. :-) I'm sure this patch is
right, but it doesn't affect me anymore.
Sorry for any problems that arose..
Cheers,
Don
prev parent reply other threads:[~2012-10-01 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 22:10 mailinfo: don't require "text" mime type for attachments Linus Torvalds
2012-10-01 13:27 ` Don Zickus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121001132746.GV1969@redhat.com \
--to=dzickus@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.