All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Bill Pemberton <wfp5p@virginia.edu>
Subject: [PATCH 1/4] localmodconfig: Set default value for ksource in streamline_config.pl
Date: Mon, 01 Oct 2012 09:30:56 -0400	[thread overview]
Message-ID: <20121001133801.334470924@goodmis.org> (raw)
In-Reply-To: 20121001133055.594443758@goodmis.org

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

From: Bill Pemberton <wfp5p@virginia.edu>

Running streamline_config.pl as it's shown it in the comment header,
you will get a warning about $ksource being uninitialized.  This is
because $ksource is set to ARGV[0], but the examples don't require any
arguments.  Fix by setting ksource to . if no ARGV[0] is given.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 scripts/kconfig/streamline_config.pl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
index 2fbbbc1..e3687f9 100644
--- a/scripts/kconfig/streamline_config.pl
+++ b/scripts/kconfig/streamline_config.pl
@@ -135,7 +135,7 @@ GetOptions("localmodconfig" => \$localmodconfig,
 	   "localyesconfig" => \$localyesconfig);
 
 # Get the build source and top level Kconfig file (passed in)
-my $ksource = $ARGV[0];
+my $ksource = ($ARGV[0] ? $ARGV[0] : '.');
 my $kconfig = $ARGV[1];
 my $lsmod_file = $ENV{'LSMOD'};
 
-- 
1.7.10.4



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2012-10-01 13:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-01 13:30 [PATCH 0/4] [GIT PULL] localmodconfig: clean ups and fixes Steven Rostedt
2012-10-01 13:30 ` Steven Rostedt [this message]
2012-10-01 13:30 ` [PATCH 2/4] localmodconfig: Rework find_config in streamline_config.pl Steven Rostedt
2012-10-01 13:30 ` [PATCH 3/4] localmodconfig: Use 3 parameter open " Steven Rostedt
2012-10-01 13:30 ` [PATCH 4/4] localmodconfig: Use my variable for loop " Steven Rostedt
  -- strict thread matches above, loose matches on Subject: below --
2012-08-09 13:23 [PATCH 0/4] minor changes to kconfig/streamline_config.pl Bill Pemberton
2012-08-09 13:23 ` [PATCH 1/4] localmodconfig: set default value for ksource in streamline_config.pl Bill Pemberton
2012-08-09 14:07   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121001133801.334470924@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=wfp5p@virginia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.