All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: How to automatically get subsystem name for a file?
Date: Mon, 01 Oct 2012 18:49:35 +0000	[thread overview]
Message-ID: <20121001184935.GP4587@mwanda> (raw)
In-Reply-To: <CA+MoWDrjiGQtBdr_n5TEwDJDv4pDyitKqHmruCy7-ur0GwKp0w@mail.gmail.com>

On Mon, Oct 01, 2012 at 06:57:44PM +0200, Peter Senna Tschudin wrote:
> I'm trying to figure it out how to automatically get the correct
> subsystem string for putting on the first line of the commit message /
> subject of the patch message. For example:
> 
> Subject: [PATCH 001/142] arch/x86: Replace memcpy with struct assignment
>                                        ^^^^^^^^^^
> arch/x86 is only the first two levels of directories from Kernel
> source. This may not be smart enough...
> 

You have to do it manually.  Here are the relevant lines from my
patch script.

git log --oneline $fullname | head -n 10
echo "Copy and paste one of these subjects?"
read unused

You should be reading through the patch manually anyway and the
reviewer needs to read it manually.  It's not like the 20 seconds
it takes to consider which prefix to use is a big deal.

regards,
dan carpenter


  reply	other threads:[~2012-10-01 18:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-01 16:57 How to automatically get subsystem name for a file? Peter Senna Tschudin
2012-10-01 16:57 ` Peter Senna Tschudin
2012-10-01 18:49 ` Dan Carpenter [this message]
2012-10-01 19:49   ` Ezequiel Garcia
2012-10-01 19:49     ` Ezequiel Garcia
2012-10-01 20:51 ` Dan Carpenter
2012-10-02  0:31   ` Ezequiel Garcia
2012-10-02  0:31     ` Ezequiel Garcia
2012-10-02  5:12 ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121001184935.GP4587@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.