diff for duplicates of <20121003002840.GA7048@roeck-us.net> diff --git a/a/1.txt b/N1/1.txt index c0ec829..2dc9a13 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -120,7 +120,7 @@ nice cleanup. Couple of minor comments below. > I2C_CLIENT_END }; > > -/* Module parameters */ -> -static bool se_input = 1; /* Default is SE, 0 = diff */ +> -static bool se_input = 1; /* Default is SE, 0 == diff */ > -static bool int_vref = 1; /* Default is internal ref ON */ > -static int vref_mv = ADS7828_INT_VREF_MV; /* set if vref != 2.5V */ > -module_param(se_input, bool, S_IRUGO); @@ -174,7 +174,8 @@ nice cleanup. Couple of minor comments below. > for (ch = 0; ch < ADS7828_NCH; ch++) { > - u8 cmd = channel_cmd_byte(ch); > + u8 cmd = ads7828_cmd_byte(data->cmd_byte, ch); -> data->adc_input[ch] > i2c_smbus_read_word_swapped(client, cmd); +> data->adc_input[ch] = +> i2c_smbus_read_word_swapped(client, cmd); > } > data->last_updated = jiffies; > - data->valid = 1; @@ -441,9 +442,4 @@ With the cleanup, you can now use the module_i2c_driver macro. > -- > 1.7.11.4 > -> - -_______________________________________________ -lm-sensors mailing list -lm-sensors@lm-sensors.org -http://lists.lm-sensors.org/mailman/listinfo/lm-sensors +> diff --git a/a/content_digest b/N1/content_digest index 5b2227a..d23b4a8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01349215803-10999-1-git-send-email-vivien.didelot@savoirfairelinux.com\0" "From\0Guenter Roeck <linux@roeck-us.net>\0" - "Subject\0Re: [lm-sensors] [PATCH v3 1/2] hwmon: (ads7828) driver cleanup\0" - "Date\0Wed, 03 Oct 2012 00:28:40 +0000\0" + "Subject\0Re: [PATCH v3 1/2] hwmon: (ads7828) driver cleanup\0" + "Date\0Tue, 2 Oct 2012 17:28:40 -0700\0" "To\0Vivien Didelot <vivien.didelot@savoirfairelinux.com>\0" "Cc\0lm-sensors@lm-sensors.org" Jean Delvare <khali@linux-fr.org> @@ -131,7 +131,7 @@ "> \tI2C_CLIENT_END };\n" "> \n" "> -/* Module parameters */\n" - "> -static bool se_input = 1; /* Default is SE, 0 = diff */\n" + "> -static bool se_input = 1; /* Default is SE, 0 == diff */\n" "> -static bool int_vref = 1; /* Default is internal ref ON */\n" "> -static int vref_mv = ADS7828_INT_VREF_MV; /* set if vref != 2.5V */\n" "> -module_param(se_input, bool, S_IRUGO);\n" @@ -185,7 +185,8 @@ "> \t\tfor (ch = 0; ch < ADS7828_NCH; ch++) {\n" "> -\t\t\tu8 cmd = channel_cmd_byte(ch);\n" "> +\t\t\tu8 cmd = ads7828_cmd_byte(data->cmd_byte, ch);\n" - "> \t\t\tdata->adc_input[ch] > \t\t\t\ti2c_smbus_read_word_swapped(client, cmd);\n" + "> \t\t\tdata->adc_input[ch] =\n" + "> \t\t\t\ti2c_smbus_read_word_swapped(client, cmd);\n" "> \t\t}\n" "> \t\tdata->last_updated = jiffies;\n" "> -\t\tdata->valid = 1;\n" @@ -452,11 +453,6 @@ "> -- \n" "> 1.7.11.4\n" "> \n" - "> \n" - "\n" - "_______________________________________________\n" - "lm-sensors mailing list\n" - "lm-sensors@lm-sensors.org\n" - http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + > -1108ee9cec3a8fce5d20d6e2f58ef135dd720068dcf9c6b18c9fbdda1018acc2 +5c7326a02e0d899bca75bae0b7365ede0430ee6a543fb2cce9c6794fe9e56aa0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.