Re: [PATCH 2/6] imsm: Add --controller-path option for --detail-platform.

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 2269 bytes --]

On Tue, 02 Oct 2012 16:37:33 +0200 Maciej Naruszewicz
<maciej.naruszewicz@intel.com> wrote:

> Usually, 'mdadm --detail-platform -e imsm' scans all the controllers
> looking for IMSM capabilities. This patch provides the possibility
> to specify a controller to scan, enabling custom usage by other
> processes - especially with the --export switch.
> 
> $ mdadm --detail-platform
>         Platform : Intel(R) Matrix Storage Manager
>          Version : 9.5.0.1037
>      RAID Levels : raid0 raid1 raid10 raid5
>      Chunk Sizes : 4k 8k 16k 32k 64k 128k
>      2TB volumes : supported
>        2TB disks : not supported
>        Max Disks : 7
>      Max Volumes : 2 per array, 4 per controller
>   I/O Controller : /sys/devices/pci0000:00/0000:00:1f.2 (SATA)
> 
> $ mdadm --detail-platform /sys/devices/pci0000:00/0000:00:1f.2
>         Platform : Intel(R) Matrix Storage Manager
>          Version : 9.5.0.1037
>      RAID Levels : raid0 raid1 raid10 raid5
>      Chunk Sizes : 4k 8k 16k 32k 64k 128k
>      2TB volumes : supported
>        2TB disks : not supported
>        Max Disks : 7
>      Max Volumes : 2 per array, 4 per controller
>   I/O Controller : /sys/devices/pci0000:00/0000:00:1f.2 (SATA)
> 
> $ mdadm --detail-platform /sys/devices/pci0000:00/0000:00:1f.2 --export
> MD_FIRMWARE_TYPE=imsm
> IMSM_VERSION=9.5.0.1037
> IMSM_SUPPORTED_RAID_LEVELS=raid0 raid1 raid10 raid5
> IMSM_SUPPORTED_CHUNK_SIZES=4k 8k 16k 32k 64k 128k
> IMSM_2TB_VOLUMES=yes
> IMSM_2TB_DISKS=no
> IMSM_MAX_DISKS=7
> IMSM_MAX_VOLUMES_PER_ARRAY=2
> IMSM_MAX_VOLUMES_PER_CONTROLLER=4
> 
> $ mdadm --detail-platform /sys/devices/pci0000:00/0000:00:1f.0 # This 
> isn't an IMSM-capable controller
> mdadm: no active Intel(R) RAID controller found under 
> /sys/devices/pci0000:00/0000:00:1f.0
> 
> Signed-off-by: Maciej Naruszewicz <maciej.naruszewicz@intel.com>

Much better, thanks.

However there is a lot of line wrapping so I cannot apply it as-is.
Can you send it the same way you've sent previous patches?

Also there is no need to create c.controller_path.  The path name should get
put into devlist->devname, so just pass
    devlist ? devlist->devname : NULL
as the path to Detail_Platform.


Thanks,
NeilBrown


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]