From: Daniel Vetter <daniel@ffwll.ch>
To: "Lespiau, Damien" <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Try harder to complete DP training pattern 1
Date: Wed, 3 Oct 2012 16:00:07 +0200 [thread overview]
Message-ID: <20121003140007.GF5329@phenom.ffwll.local> (raw)
In-Reply-To: <CAPX-8+_X7xuWze=xL4c8vPcpJ1M+JTk2fXFcEmR=pRvOkmQ8cA@mail.gmail.com>
On Wed, Oct 03, 2012 at 02:50:19PM +0100, Lespiau, Damien wrote:
> On Wed, Sep 26, 2012 at 4:48 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > In commit cdb0e95bf571dccc1f75fef9bdad21b167ef0b37
> > Author: Keith Packard <keithp@keithp.com>
> > Date: Tue Nov 1 20:00:06 2011 -0700
> >
> > drm/i915: Try harder during dp pattern 1 link training
> >
> > extra passes were made to retry the same voltage and then retry a full
> > clock reset. However, as coverity pointed out, we never tried the full
> > clock reset as we broke out of the loop early.
>
> Took me a while to wrap my head around this one, no wonder only
> Coverity pointed out. I managed to convince myself the fix is correct
> though.
>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Picked up for -fixes, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2012-10-03 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 15:48 [PATCH] drm/i915: Try harder to complete DP training pattern 1 Chris Wilson
2012-10-03 13:50 ` Lespiau, Damien
2012-10-03 14:00 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121003140007.GF5329@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.