From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756058Ab2JCVSI (ORCPT ); Wed, 3 Oct 2012 17:18:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34303 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755369Ab2JCVSF (ORCPT ); Wed, 3 Oct 2012 17:18:05 -0400 Date: Wed, 3 Oct 2012 14:18:04 -0700 From: Andrew Morton To: Ard Biesheuvel Cc: Hugh Dickins , Kees Cook , linux-kernel@vger.kernel.org Subject: Re: Updated: [PATCH] hardening: add PROT_FINAL prot flag to mmap/mprotect Message-Id: <20121003141804.f9896690.akpm@linux-foundation.org> In-Reply-To: <506C4F29.4090303@gmail.com> References: <20120820180037.GV4232@outflux.net> <20121002153841.a03ad73b.akpm@linux-foundation.org> <506C4F29.4090303@gmail.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 03 Oct 2012 16:43:53 +0200 Ard Biesheuvel wrote: > This patch adds support for the PROT_FINAL flag to > the mmap() and mprotect() syscalls. > > The PROT_FINAL flag indicates that the requested set > of protection bits should be final, i.e., it shall > not be allowed for a subsequent mprotect call to > set protection bits that were not set already. > > This is mainly intended for the dynamic linker, > which sets up the address space on behalf of > dynamic binaries. By using this flag, it can > prevent exploited code from remapping read-only > executable code or data sections read-write. Again: has this proposal been reviewed by the glibc maintainers? If so, what was their position on it? Also, you earlier stated that "It's a more direct version of PaX's "MPROTECT" feature[1]". This is useful information. Please update the changelog to describe that PaX feature and to describe the difference between the two, and the reasons for that difference. It sounds as though the PaX developers could provide useful review input on this proposal. Do they know about it? If so, what is their position? Thanks.