Re: [PATCH][BTRFS-PROGS][V1] btrfs filesystem df

[Ilya Dryomov <idryomov@gmail.com>]

On Wed, Oct 03, 2012 at 01:43:14PM +0200, Goffredo Baroncelli wrote:
> This serie of patches updated the command "btrfs filesystem
> df". I update this command because it is not so easy to get
> the information about the disk usage from the command "fi df" and "fi show".
> 
> >>From the man page (see 2nd patch):
> 
> [...]
> The  command  btrfs  filesystem  df is used to query the
> status of the chunks, how many space on the disk(s) are used  by
> the  chunks,  how many space are available in the chunks, and an
> estimation of the free space of the filesystem.
> [...]
> 
> $ ./btrfs filesystem df --help
> usage: btrfs filesystem disk-usage [-d][-s][-k] <path> [<path>..]
> 
>     Show space usage information for a mount point(s).
> 
>     -k  Set KB (1024 bytes) as unit
>     -s  Don't show the summary section
>     -d  Don't show the detail section

Hi Goffredo,

Why not show just the summary section by default and have a flag (-v)
for the details section?

> $ ./btrfs filesystem df /
> Path: /
> Summary:
>   Disk_size:                 72.57GB
>   Disk_allocated:            25.10GB
>   Disk_unallocated:          47.48GB
>   Logical_size:              23.06GB
>   Used:                      11.01GB
>   Free_(Estimated):          55.66GB    (Max: 59.52GB, Min: 35.78GB)
>   Data_to_disk_ratio:           92 %
> 
> Details:
>   Chunk-type  Mode      Chunk-size Logical-size        Used

"Type" for the first column is probably enough.

Why is the third column called Chunk-size?  If my understanding is
correct, it's just a break down of Disk_allocated from the summary
section.  If so, why not call it Disk_allocated to avoid confusion?

Also, why do you use dashes instead of underbars for table headers?

Thanks,

		Ilya