All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: [nfc:nfc-next 34/34] drivers/nfc/pn544/pn544.c:717:6: sparse: symbol 'pn544_hci_event_received' was
Date: Wed, 03 Oct 2012 16:31:53 +0000	[thread overview]
Message-ID: <20121003163153.GA14674@localhost> (raw)

[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]

Hi Eric,

FYI, there are new sparse warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/sameo/nfc-3.0.git nfc-next
head:   f97d5073425f5a5a8113cb3cb2e49f833513a5b6
commit: f97d5073425f5a5a8113cb3cb2e49f833513a5b6 [34/34] NFC: Separate pn544 hci driver in HW dependant and independant parts


vim +717 drivers/nfc/pn544/pn544.c

566bfae6 drivers/nfc/pn544_hci.c (Arron Wang    2012-09-27 @717) void pn544_hci_event_received(struct nfc_hci_dev *hdev, u8 gate, u8 event,
566bfae6 drivers/nfc/pn544_hci.c (Arron Wang    2012-09-27  718) 				struct sk_buff *skb)
566bfae6 drivers/nfc/pn544_hci.c (Arron Wang    2012-09-27  719) {
566bfae6 drivers/nfc/pn544_hci.c (Arron Wang    2012-09-27  720) 	struct sk_buff *rgb_skb = NULL;
566bfae6 drivers/nfc/pn544_hci.c (Arron Wang    2012-09-27  721) 	int r = 0;
566bfae6 drivers/nfc/pn544_hci.c (Arron Wang    2012-09-27  722) 
566bfae6 drivers/nfc/pn544_hci.c (Arron Wang    2012-09-27  723) 	pr_debug("hci event %d", event);
566bfae6 drivers/nfc/pn544_hci.c (Arron Wang    2012-09-27  724) 	switch (event) {
566bfae6 drivers/nfc/pn544_hci.c (Arron Wang    2012-09-27  725) 	case PN544_HCI_EVT_ACTIVATED:

The code at line 717 was first introduced by commit:
566bfae NFC: Pass hardware specific HCI event to driver

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu, Yuanhan Liu                              Intel Corporation

[-- Attachment #2: make-it-static-f97d507.diff --]
[-- Type: text/x-diff, Size: 482 bytes --]

diff --git a/drivers/nfc/pn544/pn544.c b/drivers/nfc/pn544/pn544.c
index cf34445..d5c835f 100644
--- a/drivers/nfc/pn544/pn544.c
+++ b/drivers/nfc/pn544/pn544.c
@@ -714,7 +714,7 @@ static int pn544_hci_check_presence(struct nfc_hci_dev *hdev,
 	return 0;
 }
 
-void pn544_hci_event_received(struct nfc_hci_dev *hdev, u8 gate, u8 event,
+static void pn544_hci_event_received(struct nfc_hci_dev *hdev, u8 gate, u8 event,
 				struct sk_buff *skb)
 {
 	struct sk_buff *rgb_skb = NULL;

                 reply	other threads:[~2012-10-03 16:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121003163153.GA14674@localhost \
    --to=fengguang.wu@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.