From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: sameo@linux.intel.com, ashish.jangam@kpitcummins.com,
dchen@diasemi.com, arnd@arndb.de, kernel@pengutronix.de,
dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [RFC 1/3] mfd: da9052-core: Use regmap_irq_get_virq() and fix the probe
Date: Wed, 3 Oct 2012 18:36:04 +0100 [thread overview]
Message-ID: <20121003173603.GG4360@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1349284019-31571-1-git-send-email-festevam@gmail.com>
On Wed, Oct 03, 2012 at 02:06:57PM -0300, Fabio Estevam wrote:
> + /* Allocate a virtual IRQ domain to distribute to the regmap domains */
> + da9052->virq = irq_domain_add_linear(NULL, ARRAY_SIZE(da9052_irqs),
> + &da9052_domain_ops, da9052);
> + if (!da9052->virq) {
> + ret = -EINVAL;
> + goto regmap_err;
> + }
I still don't understand what on earth this is doing, as far as I can
tell there's only one domain in the device so you're not distrubting
anything between domains and there's as many interrupts in this domain
as there are in the domain allocated by regmap which is even odder.
There doesn't seem to be anything about this driver that's unusual, why
does it need this weird code?
next prev parent reply other threads:[~2012-10-03 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 17:06 [RFC 1/3] mfd: da9052-core: Use regmap_irq_get_virq() and fix the probe Fabio Estevam
2012-10-03 17:06 ` [RFC 2/3] mfd: da9052: Introduce da9052-irq.c Fabio Estevam
2012-10-03 17:06 ` [RFC 3/3] Input: da9052_tsi.c: Use the new da9052 irq functions Fabio Estevam
2012-10-03 17:36 ` Mark Brown [this message]
2012-10-03 21:54 ` [RFC 1/3] mfd: da9052-core: Use regmap_irq_get_virq() and fix the probe Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121003173603.GG4360@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=ashish.jangam@kpitcummins.com \
--cc=dchen@diasemi.com \
--cc=dmitry.torokhov@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.