All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: kirkwood: DT board setup for Network Space v2 and parents
Date: Thu, 4 Oct 2012 07:17:35 +0200	[thread overview]
Message-ID: <20121004051735.GI21046@lunn.ch> (raw)
In-Reply-To: <20121003220916.GW31897@kw.sim.vm.gnt>

On Thu, Oct 04, 2012 at 12:09:16AM +0200, Simon Guinot wrote:
> On Wed, Oct 03, 2012 at 05:43:10PM +0200, Andrew Lunn wrote:
> > On Wed, Oct 03, 2012 at 05:14:30PM +0200, Simon Guinot wrote:
> > > This patch adds DT board setup for LaCie Network Space v2 and parents,
> > > based the Marvell Kirkwood 6281 SoC. This includes Network Space (Max)
> > > v2 and Internet Space v2.
> > 
> > Hi Simon
> > 
> > At a first look, this looks good. Also nice to see you use the new
> > gpio-fan binding.
> 
> Hi Andrew,
> 
> It is nice to have this binding. It works fine.

It good to hear that it works. There is one other board which could
use it. I plan to convert it over for 3.8.

I will take a look at other DT boards and see if there is any patterns
which might help here, for naming of a shared compatibility string.

> > Have you thought about adding a DT binding for this driver?
> 
> Yes. I am on it.

Great. Please include my CC: when you post it.

> > It would be nice if you could respin the patches for -rc1, when it
> > comes out. There are changes to Makefile.boot at least required.
> 
> OK. I will.
> 
> Note that this patch is based against the branch kirkwood/boards from
> the git repository git://git.infradead.org/users/jcooper/linux.git. Is
> that correct ?

Its a good start. However, the Makefile.boot changes were merged in in
arm-soc, and not by the Marvell maintainers in our trees. So changes
across multiple arm platforms are not in Jason's tree. -rc1 will have
all these changes, and forms the best base for a new board.

    Thanks
	Andrew

  reply	other threads:[~2012-10-04  5:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-03 15:14 [PATCH] ARM: kirkwood: DT board setup for Network Space v2 and parents Simon Guinot
2012-10-03 15:43 ` Andrew Lunn
2012-10-03 22:09   ` Simon Guinot
2012-10-04  5:17     ` Andrew Lunn [this message]
2012-10-04  5:54     ` Andrew Lunn
2012-10-04  7:53       ` Simon Guinot
2012-10-04 15:41         ` Stephen Warren
2012-10-09 11:17           ` Andrew Lunn
2012-10-09 16:26             ` Stephen Warren
2012-10-09 15:05           ` Simon Guinot
2012-10-09 16:30             ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121004051735.GI21046@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.